From owner-freebsd-current  Fri Dec  6 11:16:45 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 14BE637B401; Fri,  6 Dec 2002 11:16:44 -0800 (PST)
Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 50F6943EB2; Fri,  6 Dec 2002 11:16:42 -0800 (PST)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.5/8.12.6) id gB6JGdEk009375;
	Fri, 6 Dec 2002 20:16:39 +0100 (CET)
	(envelope-from sos)
From: Soeren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200212061916.gB6JGdEk009375@spider.deepcore.dk>
Subject: Re: Another INVARIANTS panic with ata driver
In-Reply-To: <15856.60167.577649.503653@grasshopper.cs.duke.edu>
To: Andrew Gallatin <gallatin@cs.duke.edu>
Date: Fri, 6 Dec 2002 20:16:39 +0100 (CET)
Cc: Kris Kennaway <kris@obsecurity.org>, sos@FreeBSD.ORG,
	current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL98b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

It seems Andrew Gallatin wrote:
> 
> Kris Kennaway writes:
>  > I got this on one of the gohan machines overnight.  These machines
>  > have failing disks -- I get a lot of hard read errors, but the
>  > INVARIANTS panic could better be replaced by something else.
>  > 
>  > I reported another instance of this to sos a few weeks ago but didn't
>  > hear a reply.
>  > 
> 
> I posted a patch for this earlier this week.  No reply from sos yet.
> 
> Try the following patch (its against stable but should work on
> current).  The problem is that ata_raiddisk_attach fails, causing the
> adp to be freed, so ad_print is called with a bogus pointer.  adp is
> an alias fro atadev->driver, so checking that atadev->driver != NULL
> is one way to fix this panic.

I have a semilar fix here, re@ will decide if it can go in...

-Søren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message