From owner-svn-src-all@freebsd.org Wed Aug 5 22:27:41 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A34E13AA4FF; Wed, 5 Aug 2020 22:27:41 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BMR8F3hmMz4JjR; Wed, 5 Aug 2020 22:27:41 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 457BE22D9E; Wed, 5 Aug 2020 22:27:41 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 97D038D4A388; Wed, 5 Aug 2020 22:27:38 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E9409E707C9; Wed, 5 Aug 2020 22:27:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id nyqR5Tldm7-Q; Wed, 5 Aug 2020 22:27:36 +0000 (UTC) Received: from [169.254.45.172] (unknown [IPv6:fde9:577b:c1a9:4902:1c04:979c:855d:2881]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 333F3E707B4; Wed, 5 Aug 2020 22:27:36 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Emmanuel Vadot" , "Warner Losh" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r363862 - head/sys/cam/mmc Date: Wed, 05 Aug 2020 22:27:35 +0000 X-Mailer: MailMate (2.0BETAr6146) Message-ID: <676873E2-9199-4EE5-ADEF-59A8F9E1308B@FreeBSD.org> In-Reply-To: <202008042004.074K40ls016193@repo.freebsd.org> References: <202008042004.074K40ls016193@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 22:27:41 -0000 On 4 Aug 2020, at 20:04, Emmanuel Vadot wrote: > Author: manu > Date: Tue Aug 4 20:04:00 2020 > New Revision: 363862 > URL: https://svnweb.freebsd.org/changeset/base/363862 > > Log: > mmccam: Hold the periph during init > > We need to sleep during this routine so acquire the cam hold too. Turns out that with this my /dev/sddaX.. device nodes are never created. Reverting this and things work a lot better again. > > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D25946 > > Modified: > head/sys/cam/mmc/mmc_da.c > > Modified: head/sys/cam/mmc/mmc_da.c > ============================================================================== > --- head/sys/cam/mmc/mmc_da.c Tue Aug 4 20:02:23 2020 (r363861) > +++ head/sys/cam/mmc/mmc_da.c Tue Aug 4 20:04:00 2020 (r363862) > @@ -1109,7 +1109,9 @@ sdda_start_init_task(void *context, int pending) > { > CAM_PRIORITY_NONE); > > cam_periph_lock(periph); > + cam_periph_hold(periph, PRIBIO|PCATCH); > sdda_start_init(context, new_ccb); > + cam_periph_unhold(periph); > cam_periph_unlock(periph); > xpt_free_ccb(new_ccb); > }