Date: Tue, 17 Dec 2013 09:48:45 +0100 From: "David Demelier" <markand@malikania.fr> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/184920: [patch] games/nsnake: fix permissions and fix score file Message-ID: <20131217084847.769EEE514@postfix.malikania.fr> Resent-Message-ID: <201312170850.rBH8o1aV038722@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 184920
>Category: ports
>Synopsis: [patch] games/nsnake: fix permissions and fix score file
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 17 08:50:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: David Demelier
>Release: FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD Pomme.malikania.fr 9.2-RELEASE FreeBSD 9.2-RELEASE #1 r255916: Fri Sep 27 22:34:59 CEST 2013 root@Pomme.malikania.fr:/usr/obj/usr/src/sys/Pomme amd64
>Description:
Since the commiter switched to a custom install, the permissions were wrong. The
binary must have the setuid bit to allow scoring.
bin/nsnake will be installed as games:games and setuid set. Then we create
/var/db/nsnake for saving best scores.
>How-To-Repeat:
>Fix:
I'm currently new to staging so I hope this looks correct.
--- nsnake.diff begins here ---
--- Makefile.orig 2013-12-17 09:08:54.000000000 +0100
+++ Makefile 2013-12-17 09:38:59.000000000 +0100
@@ -15,22 +15,25 @@
OPTIONS_DEFINE= DOCS
MAN6= ${PORTNAME}.6
-PORTDOCS= CHANGELOG
-PLIST_FILES= bin/${PORTNAME}
-NO_STAGE= yes
.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}
+PLIST_SUB+= DOCS=""
+.else
+PLIST_SUB+= DOCS="@comment "
+.endif
+
do-build:
(cd ${WRKSRC} && ${CC} ${CFLAGS} -o ${PORTNAME} ${PORTNAME}.c -lcurses)
do-install:
(cd ${WRKSRC} \
- && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin \
- && ${INSTALL_MAN} ${PORTNAME}.6 ${MANPREFIX}/man/man6)
+ && ${INSTALL_PROGRAM} ${PORTNAME} ${STAGEDIR}${PREFIX}/bin \
+ && ${INSTALL_MAN} ${PORTNAME}.6 ${STAGEDIR}${MANPREFIX}/man/man6)
.if ${PORT_OPTIONS:MDOCS}
- @${MKDIR} ${DOCSDIR}
- (cd ${WRKSRC} && ${INSTALL_DATA} CHANGELOG ${DOCSDIR})
+ @${MKDIR} ${STAGEDIR}${DOCSDIR}
+ (cd ${WRKSRC} && ${INSTALL_DATA} CHANGELOG ${STAGEDIR}${DOCSDIR})
.endif
.include <bsd.port.mk>
--- /dev/null 2013-12-17 09:42:27.000000000 +0100
+++ pkg-plist 2013-12-17 09:41:10.000000000 +0100
@@ -0,0 +1,8 @@
+@owner games
+@group games
+@mode 4555
+bin/nsnake
+%%DOCS%%%%DOCSDIR%%/CHANGELOG
+@dirrmtry %%DOCSDIR%%
+@exec mkdir -p /var/db/nsnake
+@exec chown games:games /var/db/nsnake
--- nsnake.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131217084847.769EEE514>