From owner-svn-src-head@freebsd.org Fri Jul 27 19:38:52 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C70181054AF9; Fri, 27 Jul 2018 19:38:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1963184782; Fri, 27 Jul 2018 19:38:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w6RJci1O072128 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 27 Jul 2018 22:38:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w6RJci1O072128 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w6RJcica072127; Fri, 27 Jul 2018 22:38:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 27 Jul 2018 22:38:44 +0300 From: Konstantin Belousov To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336746 - in head/lib: libc/gen libutil Message-ID: <20180727193844.GD2489@kib.kiev.ua> References: <201807261834.w6QIYc9i080738@repo.freebsd.org> <20180727150304.GA2489@kib.kiev.ua> <1532705741.61594.53.camel@freebsd.org> <20180727154359.GB2489@kib.kiev.ua> <1532707631.61594.66.camel@freebsd.org> <20180727164437.GC2489@kib.kiev.ua> <1532717874.61594.79.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1532717874.61594.79.camel@freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 19:38:53 -0000 On Fri, Jul 27, 2018 at 12:57:54PM -0600, Ian Lepore wrote: > Yes, this is exactly what I think we should do after your description > of howšFBSDprivate_1.0 exists specifically to solve some interactions > between rtld, libc, and libthr. Great. > > This is what I meant when I said in one of the earlier emails: > > > I also noticed that chpass(1) and pwd_mkdb(8)_both directly compile in > > their own copy of the pw_scan.c source using .PATH in their makefiles. > > I wonder if doing that as the way of sharing the code between libc and > > libutil would be a better thing to do? (And presumably that would > > remove the need to have entries in the FBSDprivate_1.0 list?) > > So if we do that, are there any special considerations about removing > the __pw_scan entry (and now __pw_initpwd as well) from the private > list? Or can they just be deleted without needing to do anything else? > Does anything need to be done to make the __pw_scan symbol not directly > visible for linking to resolve external references? Remove them. FBSDprivate_1.0 is private and is guaranteed to be ABI-unstable. There is nothing to do to prevent linking against these symbols. If somebody decides to check if she inadvertently did that, it is enough to see if the FBSDprivate_1.0 namespace is referenced by the linked object, e.g. by 'readelf -V object' and see versions needed.