From owner-cvs-all@FreeBSD.ORG Wed Feb 11 11:24:38 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95C2D16A4CE; Wed, 11 Feb 2004 11:24:38 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F3CA43D1F; Wed, 11 Feb 2004 11:24:38 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id i1BJOXA0068090; Wed, 11 Feb 2004 11:24:33 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.10/8.12.10/Submit) id i1BJOW7X068089; Wed, 11 Feb 2004 11:24:32 -0800 (PST) (envelope-from obrien) Date: Wed, 11 Feb 2004 11:24:32 -0800 From: "David O'Brien" To: Joe Marcus Clarke Message-ID: <20040211192432.GB68010@dragon.nuxi.com> References: <200402110716.i1B7GH9D017803@repoman.freebsd.org> <1076516832.1486.2.camel@gyros> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1076516832.1486.2.camel@gyros> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: Dag-Erling Sm?rgrav cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/firefox Makefile distinfo pkg-descr pkg-message pkg-plist ports/www/firefox/files firebird.rb firefox.rb mkdistfile mozconfig.in patch-Double.cpp patch-build_unix_run-mozilla.sh patch-config-mkdepend-imakemdep.h patch-config-rules.mk ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2004 19:24:38 -0000 On Wed, Feb 11, 2004 at 11:27:12AM -0500, Joe Marcus Clarke wrote: > On Wed, 2004-02-11 at 08:58, Dag-Erling Sm?rgrav wrote: > > Joe Marcus Clarke writes: > > > * Use PERL instead of REINPLACE_CMD in a few places [1] > > > > Sounds like a regression to me. What's wrong with REINPLACE_CMD? > > Not really a regression since this port requires Perl anyway. However, > I was not the one that did this, and the more I thought about it, it > seemed to be gratuitous to me. But as the one that committed it, you should have reviewed and agreed with the change. -- -- David (obrien@FreeBSD.org)