From nobody Fri Nov 11 18:37:00 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N86qw3Wpqz4dbng; Fri, 11 Nov 2022 18:37:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N86qw1wjkz3wLF; Fri, 11 Nov 2022 18:37:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668191820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AFSyluXOcBY/s4L2mP7/nsGOLmLt+zncZKRqQfRa4SU=; b=jgEcXMO+VW+azmi2Napk9PURiJt6E1xGTI2aq/GEdMxuRZ6dboY3J9pDcnKwn6gLb5joqq Jtb/vf1Wvf/m3JFUyyPzMlkN1IweoBhmNNoA+cPY6FWGlqTSQf79/kCLiLuilYN3c1GBHV Ro9wjSAeeXE7hDlTHdoxB7ewlXLGV4U6Qv4am5EUrziSV6DTvQRXDMp4D669a/HLaIFZRz dG1xe07OqSm186RWFRI1xOEC+mWnFhTTV+ynOMTwDzUujCFngJxLm76zLV50YpfPTT5H03 +ZPtrMa+4D5Zii5ckC0K6ipFw3UDYzt7ZXYHXmDvEbhkOc8LgphVvyJ7/8EUaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668191820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AFSyluXOcBY/s4L2mP7/nsGOLmLt+zncZKRqQfRa4SU=; b=DjCjHC4kWyH+mr+PxIEi388tM709/SNlkm+VDd3byZyaLF4mcwv0G+U/e0ruIsFjr1Y5vx u7kP19ufNk8JLKjO6tnUnv1Ox7kynEiFQG+h3Hzrwjl601okZNTLEP5nXctVv6Nj+MQZWo FNOj6PNCUhHsLCz96aHKdx1StTwbDUIlnOco3xb8LWQl3yWx+uKJJP4PHVH/pGxY9KapCE 9TILPGQ8wubbgKRz+/Z7/u3Vo0/dbFbnMlN1FZjlKxPNb41cUfykg38+F2QZK5KTljwhUX XGvuoRK3J8rhm/dPdqhJNv6dsbxCmGxP9YVz9XYlnDzAEtmB7tu/lzpz+WXeOg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668191820; a=rsa-sha256; cv=none; b=i9rJTWd8k0TkA6RRjvo1BWkzplts1+TsilGOnWU7VMB+j8yoOLFAXICsh+hymxg0IhfYbf U4W6lcOVDg91ilKeBi6sp1ic56zn0kV+pTDwcuEhTW4wU51QTpd5f3e0b72QNIq6cFO3sO Bdmbi4kUP19+Zpkn24Ky71IxuXFf+U+aPijO3wGji0trBwIKDQ4ARsFNQKxNsfaPIU8WPc kbLGXwhu55+/B5nPAlK0KQ4fykxlOd1XK63d3XWdfNyfrDDVuivvqiXBj1Ae4QbBIkGz2I YychNbt0QyEsDB1BoJjc0lTh5dQmmrJMQrlpahJnPrDMfC6lWsPl/LfBiegnwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N86qw11llzt2t; Fri, 11 Nov 2022 18:37:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ABIb09x004336; Fri, 11 Nov 2022 18:37:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ABIb0X1004335; Fri, 11 Nov 2022 18:37:00 GMT (envelope-from git) Date: Fri, 11 Nov 2022 18:37:00 GMT Message-Id: <202211111837.2ABIb0X1004335@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 6728d270e132 - stable/13 - bhyve: Don't free an invalid pointer. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 6728d270e132846d9a45808d56f957a1b5c7a783 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=6728d270e132846d9a45808d56f957a1b5c7a783 commit 6728d270e132846d9a45808d56f957a1b5c7a783 Author: John Baldwin AuthorDate: 2022-10-03 23:10:44 +0000 Commit: John Baldwin CommitDate: 2022-11-11 18:18:54 +0000 bhyve: Don't free an invalid pointer. The netmap-specific data stored at be->opaque is freed by the caller on error as part of freeing be. Reviewed by: markj Reported by: GCC -Wfree-nonheap-object Differential Revision: https://reviews.freebsd.org/D36828 (cherry picked from commit 2fb81691b02f27fa938f311835a8c6704c5cf80f) --- usr.sbin/bhyve/net_backends.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/bhyve/net_backends.c b/usr.sbin/bhyve/net_backends.c index 16a3d831aaa3..5b4a2c0ae257 100644 --- a/usr.sbin/bhyve/net_backends.c +++ b/usr.sbin/bhyve/net_backends.c @@ -695,7 +695,6 @@ netmap_init(struct net_backend *be, const char *devname, if (priv->nmd == NULL) { WPRINTF(("Unable to nm_open(): interface '%s', errno (%s)", devname, strerror(errno))); - free(priv); return (-1); }