Date: Wed, 09 Dec 2015 20:37:33 +0000
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 204607] [NEW PORTS] database/mysql57-{client,server}: Multithreaded SQL database
Message-ID: <bug-204607-13-QmLUhFzhY2@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204607-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-204607-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204607 --- Comment #19 from Bernard Spil <brnrd@freebsd.org> --- Great work! Don't worry about all the feedback you'll be getting, we strive for quality and this is part of that process. That's also part of learning porting, the higher the quality of material you supply, the faster it will be committed. Things that need solving: 1. MYSQL57_LIBVER must go into Mk/bsd.databases.mk otherwise other ports will fail on the libver. This also means that portmgr@ gets involved! 2. The commented out lined of CMAKE_ARGS should go or be enabled. (you should at least provide the ssl options, see the mariadb100-server port for example) 3. MAKE_JOBS_UNSAFE? Is that really required? None of the other mysql ports have that set. 4. portlint -AC can be a lot cleaner USE_LDCONFIG+= ${PREFIX}/lib/mysql/plugin works for mariadb101-server make clean extract do-patch mv files orig.files make makepatch diff -rq orig.files files merge what you need back into files LICENSE= GPLv2? 5. bison can probably be bison:build If anyone wants to know: MySQL as of 5.7 has a HARD dependency on a version of boost. We can never keep ports' version of boost in line with mysql so this must be embedded here. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204607-13-QmLUhFzhY2>