From owner-svn-src-all@freebsd.org Wed May 22 16:36:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D890915B0D5C; Wed, 22 May 2019 16:36:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 761A08E250; Wed, 22 May 2019 16:36:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 67C2418258; Wed, 22 May 2019 16:36:12 +0000 (UTC) Date: Wed, 22 May 2019 16:36:12 +0000 From: Alexey Dokuchaev To: Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r244943 - in head/sys/dev/ath/ath_hal: ar5416 ar9002 Message-ID: <20190522163612.GA4626@FreeBSD.org> References: <201301020038.r020c1fN074342@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201301020038.r020c1fN074342@svn.freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 761A08E250 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.93 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.937,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 16:36:13 -0000 On Wed, Jan 02, 2013 at 12:38:01AM +0000, Adrian Chadd wrote: > New Revision: 244943 > URL: http://svnweb.freebsd.org/changeset/base/244943 > > Log: > Bring over the basic spectral scan framework code from Qualcomm Atheros. > > This includes the HAL routines to setup, enable/activate/disable spectral > scan and configure the relevant registers. > > Obtained from: Qualcomm Atheros > > Added: > head/sys/dev/ath/ath_hal/ar5416/ar5416_spectral.c > > ... > + if (ss->ss_period != HAL_SPECTRAL_PARAM_NOVAL) { > + val &= ~AR_PHY_SPECTRAL_SCAN_PERIOD; > + val |= SM(ss->ss_period, AR_PHY_SPECTRAL_SCAN_PERIOD); > + } > + > + if (ss->ss_period != HAL_SPECTRAL_PARAM_NOVAL) { > + val &= ~AR_PHY_SPECTRAL_SCAN_PERIOD; > + val |= SM(ss->ss_period, AR_PHY_SPECTRAL_SCAN_PERIOD); > + } PVS Studio complains here: warning: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. ./danfe