From owner-cvs-all@FreeBSD.ORG Wed Sep 20 12:28:32 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AD5316A40F; Wed, 20 Sep 2006 12:28:32 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B1343D76; Wed, 20 Sep 2006 12:28:30 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id E15335DF9; Wed, 20 Sep 2006 16:28:28 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id C0D445DDE; Wed, 20 Sep 2006 16:28:28 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k8KCSUTk002211; Wed, 20 Sep 2006 16:28:30 +0400 (MSD) (envelope-from ru) Date: Wed, 20 Sep 2006 16:28:30 +0400 From: Ruslan Ermilov To: Marius Strobl Message-ID: <20060920122830.GB982@rambler-co.ru> References: <20060919190645.GA23068@rambler-co.ru> <20060919194819.GA23360@rambler-co.ru> <20060919203608.GE23360@rambler-co.ru> <20060919215605.GB44298@rambler-co.ru> <20060919221404.GT94944@alchemy.franken.de> <20060920055715.GA81843@rambler-co.ru> <20060920121017.GU94944@alchemy.franken.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5/uDoXvLw7AC5HRs" Content-Disposition: inline In-Reply-To: <20060920121017.GU94944@alchemy.franken.de> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Maksim Yevmenkin Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2006 12:28:32 -0000 --5/uDoXvLw7AC5HRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 20, 2006 at 02:10:17PM +0200, Marius Strobl wrote: > On Wed, Sep 20, 2006 at 09:57:15AM +0400, Ruslan Ermilov wrote: > > On Wed, Sep 20, 2006 at 12:14:04AM +0200, Marius Strobl wrote: > > > On Wed, Sep 20, 2006 at 01:56:05AM +0400, Ruslan Ermilov wrote: > > > >=20 > > > > The proper fix would be to fix the kernel to pass an argument by > > > > value, like the userland does. But from the practical point of > > > > view, it may make sense to change the API and say that these > > > > IOCTLs now take a pointer type argument. I'm not sure. If you > > > > know of any applications (mine test util not counting :-) that > > > > use KDSKBMODE/KDSETLED/KDSKBSTATE, then we should probably fix > > > > the kernel callers. > > >=20 > > > XFree86/Xorg use KDSKBMODE and KDSETLED, see f.e. the Xorg > > > "kbd" driver: > > > http://webcvs.freedesktop.org/xorg/xserver/xorg/hw/xfree86/os-support= /bsd/bsd_kbd.c?revision=3D1.8&view=3Dmarkup > > >=20 > > Hmm, but they don't work on sparc64. How X.Org ever works then? > > I remember installing it on my sparc64 laptop... >=20 > KDSETLED just never worked on sparc64 so far (from userland...), > keyboard LEDs just don't get lit when in X. As for KDSKBMODE > K_RAW is defined as 0 so X happens to put the keyboard into > raw mode as expected and syscons(4) makes sure that the > keyboard is in translate mode in sccngetch(). So apart from > the keyboard LEDs keyboards just happen to work in X and > when back on the console on sparc64. >=20 OK, good to know, thanks! I have a real fix in the works, just scanning the entire tree for other IOCTLs like this. With this fix, the LEDs should start working without recompiling the X. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --5/uDoXvLw7AC5HRs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFETPuqRfpzJluFF4RAnnwAJ9fdUjilijztq1VBJyNUvL+B4C4GACfQTT5 2ugunBndV+Us1yoDCzbQk5A= =3WJj -----END PGP SIGNATURE----- --5/uDoXvLw7AC5HRs--