From owner-svn-ports-all@freebsd.org Tue Nov 22 10:12:34 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F6B7C4F71C; Tue, 22 Nov 2016 10:12:34 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-wj0-x242.google.com (mail-wj0-x242.google.com [IPv6:2a00:1450:400c:c01::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2296B1D22; Tue, 22 Nov 2016 10:12:34 +0000 (UTC) (envelope-from kubito@gmail.com) Received: by mail-wj0-x242.google.com with SMTP id f8so5903074wje.2; Tue, 22 Nov 2016 02:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=vlH6fHDsSVi+Q7OIalwO8o85oEHNBJeW2u4qjEEokfc=; b=iuCupkyLYu8wn3Wos4NuCm6SJycM51TBI9AiEaIvpQ69eRy2Qs85sCKQk2tGdSvfl4 +4vWhGTd1tFjDBzf2Xt3XxB3qCbw5jPuqsk88sIXQJDGvoDwfeuXyWtN5++mlH5pm0yu +xFXmhqmKgLb4ZW5SToDQRpt4rKTmlnW+4EvR1lhuI3v+a6A0+YZg5gJxhhWe0mDoaJD B+j/7rQwmJY95vdGHHcVRqaHGfRs2zG/FJ6q5FcFzW+amX5eprM7/8Y/cjQLF46oi5NE vtmY57XsqV+t/+wJVytiK+i0+xR0ulPcdKi7dVyxbo0ovSYM7v3m/vL+oij3+MdefbUZ A0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=vlH6fHDsSVi+Q7OIalwO8o85oEHNBJeW2u4qjEEokfc=; b=QwAVanaxGYL69vfGdTNvsYoEDmcP3jqXhHutfT5VNeNoUleGZw7pXP1D9AEHfTJQoq ScVVQp566MNeJHpParN9vaJyr3zgbYmb2UB9xebdmrWC+JB5+zf34QLm42mNsZ3biW4U P2xzb92WfO3K6xA+aetIjZoreM4/pSKnXEU9E/Zbc4cwbAqezWudgWdSPuJQdQ1qleN4 TZVsIDIuX0d9KGf2FWYwcSh4obvCc19ZoZo7AR93xV7wpZtoC5aCfV6ehEtHaKzyX6ny lla/dEvekrw5BtDQ8OILbWYNy7b9pZ+LaegQ/dWc/tFCXZqikgzcBAIvjBaI7yTXwmzW 0laA== X-Gm-Message-State: AKaTC00KQPph7V2j7CjY3Wpe2Ew3vos+rxTfaOxmViQK9Vrkzb391/bE5Nuv25HRsANAkA== X-Received: by 10.194.205.34 with SMTP id ld2mr13058022wjc.211.1479809552001; Tue, 22 Nov 2016 02:12:32 -0800 (PST) Received: from orwell.gmail.com (dhcp-077-248-147-050.chello.nl. [77.248.147.50]) by smtp.gmail.com with ESMTPSA id b15sm2100943wma.5.2016.11.22.02.12.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Nov 2016 02:12:31 -0800 (PST) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r426759 - in head/databases/xapian-core: . files References: <201611212126.uALLQxT0063108@repo.freebsd.org> Date: Tue, 22 Nov 2016 11:12:20 +0100 In-Reply-To: (Mathieu Arnold's message of "Tue, 22 Nov 2016 00:17:53 +0100") Message-ID: <86oa17lt6j.fsf@FreeBSD.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2016 10:12:34 -0000 Mathieu Arnold writes: > Le 21/11/2016 =C3=A0 22:26, Raphael Kubo da Costa a =C3=A9crit : > >> SOCK_CLOEXEC was introduced in FreeBSD 10, so define it to 0 on FreeBS= D 9 (the >> code already handles this case). Xapian 1.4 has a safesyssocket.h that= does the >> same thing. > > But FreeBSD 10 is not 1000000. In that case, according to > sys/sys/socket.h's log, it was added in r248534, the closest version is > 1000031. I tried looking for a specific entry mentioning SOCK_CLOEXEC in the porter's handbook and decided to go with 1000000 after not finding anything. I'm fine with adjusting the check, but given 1000031 predates even the branching of FreeBSD 10 and the minimum 10.x version we currently support is 10.1, does it make sense to do that?