From owner-freebsd-current Tue Aug 11 07:25:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA05974 for freebsd-current-outgoing; Tue, 11 Aug 1998 07:25:22 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from lor.watermarkgroup.com (lor.watermarkgroup.com [207.202.73.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA05959 for ; Tue, 11 Aug 1998 07:25:15 -0700 (PDT) (envelope-from luoqi@watermarkgroup.com) Received: (from luoqi@localhost) by lor.watermarkgroup.com (8.8.8/8.8.8) id KAA27035; Tue, 11 Aug 1998 10:12:49 -0400 (EDT) (envelope-from luoqi) Date: Tue, 11 Aug 1998 10:12:49 -0400 (EDT) From: Luoqi Chen Message-Id: <199808111412.KAA27035@lor.watermarkgroup.com> To: archer@lucky.net, bde@zeta.org.au, current@FreeBSD.ORG, luoqi@watermarkgroup.com Subject: Re: New softupdates code panics Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > >> The same here. My system paniced two times for some 4 hours after > >> I've booted kernel with Kirk's patches. The system was not very > >> busy, just ordinary mail/news reception (it is home computer). > >> > >Change the expression ``newparent ? newparent : doingdirectory'' in Kirk's > >patch to ``doingdirectory && newparent ? newparent : doingdirectory''. > >(for file ufs/ufs/ufs_vnops.c) > > Um, this expression is equivalent to ``doingdirectory'', which is the > same as the unpatched expression. General fuzzy reasoning suggests that > the expression should be ``doingdirectory && !newparent''. > > Bruce > newparent is not a boolean, and neither is the expression, they are integers. The expression used to be boolean, but now we want it to have three states: 0, 1, and >1, with the third state be doingdirectory && newparent. You could write the expression as ``doingdirectory && newparent ? 2 : doingdirectory''. -lq To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message