From owner-freebsd-bugs Thu Apr 25 16:34:42 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 5076A37B427 for ; Thu, 25 Apr 2002 16:34:24 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 8CE6881675; Fri, 26 Apr 2002 09:04:20 +0930 (CST) Date: Fri, 26 Apr 2002 09:04:20 +0930 From: Greg 'groggy' Lehey To: Poul-Henning Kamp Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/37458: twed (3ware escalade) devices not supported by vinum Message-ID: <20020426090420.R33950@wantadilla.lemis.com> References: <200204251830.g3PIU8i38773@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200204251830.g3PIU8i38773@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Thursday, 25 April 2002 at 11:30:08 -0700, Poul-Henning Kamp wrote: > The following reply was made to PR bin/37458; it has been noted by GNATS. > > From: Poul-Henning Kamp > To: holger.kipp@alogis.com > Cc: FreeBSD-gnats-submit@FreeBSD.ORG > Subject: Re: bin/37458: twed (3ware escalade) devices not supported by vinum > Date: Thu, 25 Apr 2002 20:21:55 +0200 > > While this patch is technically correct, the code it patches is > mightily bogus. >> *** vinumio.c.orig Tue Apr 23 13:05:19 2002 >> --- vinumio.c Tue Apr 23 13:22:57 2002 >> *************** >> *** 93,98 **** >> --- 93,101 ---- >> } else if (bcmp(dname, "idad", 4) == 0) { >> devmajor = 109; >> dname += 2; >> + } else if (bcmp(dname, "twed", 4) == 0) { /* 3ware raid */ >> + devmajor = 147; >> + dname += 2; >> } else You obviously haven't read the comments. /* * Yes, Bruce, I know this is horrible, but we * don't have a root file system when we first * try to do this. If you can come up with a * better solution, I'd really like it. I'm * just putting it in now to add ammuntion to * moving the system to devfs. */ Feel free to improve on it. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message