From owner-cvs-all Sun May 13 22:26:53 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 92A8737B423; Sun, 13 May 2001 22:26:50 -0700 (PDT) (envelope-from tanimura@FreeBSD.org) Received: (from tanimura@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f4E5Qo547008; Sun, 13 May 2001 22:26:50 -0700 (PDT) (envelope-from tanimura) Message-Id: <200105140526.f4E5Qo547008@freefall.freebsd.org> From: Seigo Tanimura Date: Sun, 13 May 2001 22:26:50 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern sys_generic.c src/sys/netncp ncp_sock.c src/sys/netsmb smb_trantcp.c src/sys/sys systm.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG tanimura 2001/05/13 22:26:50 PDT Modified files: sys/kern sys_generic.c sys/netncp ncp_sock.c sys/netsmb smb_trantcp.c sys/sys systm.h Log: - Convert msleep(9) in select(2) and poll(2) to cv_*wait*(9). - Since polling should not involve sleeping, keep holding a process lock upon scanning file descriptors. - Hold a reference to every file descriptor prior to entering polling loop in order to avoid lock order reversal between lockmgr and p_mtx upon calling fdrop() in fo_poll(). (NOTE: this work has not been done for netncp and netsmb yet because a socket itself has no reference counts.) Reviewed by: jhb Revision Changes Path 1.78 +132 -41 src/sys/kern/sys_generic.c 1.5 +14 -10 src/sys/netncp/ncp_sock.c 1.2 +14 -10 src/sys/netsmb/smb_trantcp.c 1.140 +2 -2 src/sys/sys/systm.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message