From owner-freebsd-current@FreeBSD.ORG  Fri Aug 22 09:53:15 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0E9B216A4BF
	for <current@freebsd.org>; Fri, 22 Aug 2003 09:53:15 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 4140D43F85
	for <current@freebsd.org>; Fri, 22 Aug 2003 09:53:14 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 4499 invoked by uid 1000); 22 Aug 2003 16:53:14 -0000
Date: Fri, 22 Aug 2003 09:53:14 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Andrew Thompson <andy@fud.org.nz>
In-Reply-To: <1060413953.33258.18.camel@localhost>
Message-ID: <20030822094621.T4440@root.org>
References: <20030806213504.S74720@root.org>
	<03Aug8.140932nzst.119071@homer.fire.org.nz>
	<1060346467.33258.3.camel@localhost> 
	<1060413953.33258.18.camel@localhost>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Re: USB da(4) quirks deprecated
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Aug 2003 16:53:15 -0000

On Sat, 9 Aug 2003, Andrew Thompson wrote:
> On Fri, 2003-08-08 at 15:41, Nate Lawson wrote:
> I have applied Kevins DA_Q_NO_PREVENT patch and now the device is
> working perfectly, here is the diff and new dmesg.
>
> Thanks Nate and Kevin for your help.  Should I send a PR?

Please do and then send me the #.

> dmesg:
> umass0: SigmaTel, Inc. USBMSC Audio Player, rev 1.10/0.01, addr 3
> umass0: Get Max Lun not supported (IOERROR)
> Enabling quirks for device
> da0 at umass-sim0 bus 0 target 0 lun 0
> da0: <SigmaTel MSCN 0001> Removable Direct Access SCSI-4 device
> da0: 1.000MB/s transfers
> da0: 125MB (256001 512 byte sectors: 64H 32S/T 125C)

> scsi_da.c.diff:
> @@ -228,6 +229,10 @@
>                 {T_DIRECT, SIP_MEDIA_FIXED, quantum, "VIKING 2*", "*"},
>                 /*quirks*/ DA_Q_NO_6_BYTE
>         },
> +       {
> +               {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel*", "MSCN*",
> "*"},
> +               /*quirks*/
> DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
> +       },
>
>  #ifdef DA_OLD_QUIRKS
>         /* Below a list of quirks for USB devices supported by umass. */

The NO_PREVENT support has been added.  Does this work for you?
       {
           {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel", "MSCN", "*"},
            /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
       },

-Nate