From owner-svn-src-head@freebsd.org Fri Jun 28 23:27:25 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3DEA915CED84; Fri, 28 Jun 2019 23:27:25 +0000 (UTC) (envelope-from mhorne063@gmail.com) Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFFF88D390; Fri, 28 Jun 2019 23:27:24 +0000 (UTC) (envelope-from mhorne063@gmail.com) Received: by mail-ot1-x344.google.com with SMTP id d17so7680509oth.5; Fri, 28 Jun 2019 16:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UU6mYjfhH9RH0RijFBft+NcEpD4uqF9MacTQ+c0GUsw=; b=I8q8Moca94+YBfbvra40PXH550l/ra9Gubn04DhnlJMkMLl9gp9JIdDAcM/vBgsYVm //q1aZjRet+gC3BLLZie3cDfLFqYGnw6PCKOpd30p3Btamcx/1PKuPeM0wqwAqqdCF+l Sw2ns9OXk/xdf0ZC9+N7U4KJx4mUa8NFAfRuDExu5kB0h3Zto3JppltB0OuFLucCZgI4 caGj7ta2KdSrrs4hk2CfPzJnFK9kCx5jgHTs+y4YMMGEBoigxHEyicJQJlciPEUh+a/K /+OKYIc5ulsvW7NsmLxxlkNZ5/riGwLUN/psNjT8+ECrLrYDg+zZaTBkkoyEW1cgGdCr 8eOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UU6mYjfhH9RH0RijFBft+NcEpD4uqF9MacTQ+c0GUsw=; b=D9aXcO21uID9xABfaebej4wZi/V2WtBXdaqYN/G/QaAjsWhMwuweTQdc8xLyVhpPca csttksx/tISqEkh1/GoQ09Xvurb7MDb7DvPTVYW8W4gTo3rT/DiOCYg0oTdM2PtZ1opN VOjsUt43KhfzBFywf2D54fsuWRwDr3ntrLPVizUb5YWCA2Y2b9MPWs5FDJCne3y2uZsD BRoJrmX30Bh2wQo6elp2K1mYcuj2JtIMyjvSq/8I5jMR12REev7eY/I8ICq9qcJ1EzQ1 82hBiUFm+XqH2GNlLduJ8V/AbLxKkCuR2+PNTtJ9dapDhO2oUmG933PDm6xdIktTvAjr 1gPw== X-Gm-Message-State: APjAAAUwXD5dZmUqgbK3I0HXeTzm4YNGyk35kIIgn2NpccemVm/XwLab brKqPMCsKp4enoSqjersgIzwVj/JOsTvrHj9ed7oWQ== X-Google-Smtp-Source: APXvYqzOW0U0v11xeHlT6Z91smtO2SbPKAhc2SknhUBhBzLpCX3JqEwc2gI+urg5rUtTz0+T+6qhxoHe7hj8brKnCew= X-Received: by 2002:a9d:68d7:: with SMTP id i23mr9383617oto.124.1561764443463; Fri, 28 Jun 2019 16:27:23 -0700 (PDT) MIME-Version: 1.0 References: <201906280010.x5S0ARLh056619@repo.freebsd.org> In-Reply-To: From: Mitchell Horne Date: Fri, 28 Jun 2019 19:27:12 -0400 Message-ID: Subject: Re: svn commit: r349482 - in head/contrib/elftoolchain: common readelf To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CFFF88D390 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.922,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2019 23:27:25 -0000 On Fri, Jun 28, 2019 at 12:45 PM John Baldwin wrote: > > On 6/27/19 5:10 PM, Mitchell Horne wrote: > > Author: mhorne > > Date: Fri Jun 28 00:10:26 2019 > > New Revision: 349482 > > URL: https://svnweb.freebsd.org/changeset/base/349482 > > > > Log: > > readelf: Add support for RISC-V specific e_flags > > > > Reviewed by: markj > > Approved by: markj (mentor) > > MFC after: 3 days > > Differential Revision: https://reviews.freebsd.org/D20767 > > > > Modified: > > head/contrib/elftoolchain/common/elfdefinitions.h > > head/contrib/elftoolchain/readelf/readelf.c > > > > Modified: head/contrib/elftoolchain/common/elfdefinitions.h > > ============================================================================== > > --- head/contrib/elftoolchain/common/elfdefinitions.h Fri Jun 28 00:03:29 2019 (r349481) > > +++ head/contrib/elftoolchain/common/elfdefinitions.h Fri Jun 28 00:10:26 2019 (r349482) > > @@ -426,6 +426,22 @@ _ELF_DEFINE_EF(EF_PPC_RELOCATABLE, 0x00010000UL, \ > > "-mrelocatable flag") \ > > _ELF_DEFINE_EF(EF_PPC_RELOCATABLE_LIB, 0x00008000UL, \ > > "-mrelocatable-lib flag") \ > > +_ELF_DEFINE_EF(EF_RISCV_RVE, 0x00000008UL, \ > > + "Compressed instruction ABI") \ > > I don't think this description for RVE is quite right. RVE is for RV32E which > is not using compressed ('C') instructions, but using a smaller register file > (16 GPRs instead of 32) which is in theory intended for embedded / microprocessor > variants. The riscv-elf-psabi-doc describes it as: > > EF_RISCV_RVE (0x0008): This bit is set when the binary targets the E ABI. > Yep, good catch. This got duplicated from the RVC entry and slipped by during review. I'll adjust it. Mitchell > -- > John Baldwin