From owner-freebsd-net@freebsd.org Tue May 18 15:46:50 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE7ED65068A for ; Tue, 18 May 2021 15:46:50 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fl0jj5xNHz4qbj; Tue, 18 May 2021 15:46:49 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: by mail-wm1-x32f.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so1812881wmk.1; Tue, 18 May 2021 08:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=JsJxYA0iIElrFAxleK/zLz2SC0dYxkiDxcb0UyFbWoU=; b=E8IbE5oF5XSQvRn9TrR0r4ETuHxTlvLVv3HeudwpdN2I3f+ZAXOYyJZHBt7JzwuF/a I+7d5lEIK1oce+mu7B+rUHEst7iDaR15UcgqL1dGZNlin/kI3Z/jejBDrml+wDuYBD+h g5QRp4qTQ0hKEHKPcNG1evHgc+ng0BKXGxTCnvbrSs74CvVZBSAzXjFjg3bEvQ3Cm3oh ILoWaEL8hGzG8YEPzhoGSaioE398H9dXuiOhdhPFIKZQdyNhMvq4yrqyIVV6G+2J2qyS fbqYEQzImkx4o+ADK/9F/NmYZTg46hMxgSTl/P/8AgCDiNIBq2Zz8j7VB2d91vxLyU1K KFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=JsJxYA0iIElrFAxleK/zLz2SC0dYxkiDxcb0UyFbWoU=; b=Ft4Ucl6WVzy2ncM+rkPKEVY/WdYm3qzAvZWe1jFln2IWLlUBS0he6J0t3HVT8Y4t8R WDOmc+yOkY5R0f2/ZSyvBHZZt+yHX4p3emtpUcfaXibxfOLZIdZ1KbWr4Fk8LNY+D4Ib ciOlv9cB8bux0HgZ0XqXtnGrBJj8T/THxqB/neSqYX6GZ9A1HjX+Jls5SvYUC/iMgIpZ tFYh9zhlgh6HdJNHQo8uVGbtzUqLkRd655LGCNKw9YVGFmuPxPamaaUziePgamHKuvx8 zViPKo5mdma8aCfpmspWg2/QWiEvshpg7l3V9s1oYQUu6+jhsXMqqpkBw8VaxKQkZPbv 31Xw== X-Gm-Message-State: AOAM5300TLGj5wOCZF3ZypmJJKRsOI8SPVgc0jRZ3+B9oZFW0ckZt28v 9aEkpvE52WxT0AasicaD4rJ2BVYHD/4W4A== X-Google-Smtp-Source: ABdhPJwc///z2J8foiKPfWd7vv2ZCvjL4zMJJDFwMnwyB9WdC8KgPtXuEizltue4yXMxKGYOJJm73w== X-Received: by 2002:a1c:2802:: with SMTP id o2mr6161277wmo.170.1621352807492; Tue, 18 May 2021 08:46:47 -0700 (PDT) Received: from ?IPv6:2a0d:6fc2:51d2:1d01:7e58:ffdd:ca53:e6f1? ([2a0d:6fc2:51d2:1d01:7e58:ffdd:ca53:e6f1]) by smtp.gmail.com with ESMTPSA id s15sm3050221wrt.54.2021.05.18.08.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 08:46:47 -0700 (PDT) To: "Alexander V. Chernikov" , freebsd-net@freebsd.org From: Guy Yur Subject: fib[46]_lookup_rt usage in netflow.c, sa_len comparison with AF_INET Message-ID: Date: Tue, 18 May 2021 18:46:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 4Fl0jj5xNHz4qbj X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=E8IbE5oF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of guyyur@gmail.com designates 2a00:1450:4864:20::32f as permitted sender) smtp.mailfrom=guyyur@gmail.com X-Spamd-Result: default: False [1.92 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::32f:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.95)[0.945]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.99)[0.985]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::32f:from:127.0.2.255]; NEURAL_SPAM_LONG(0.99)[0.994]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::32f:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 15:46:50 -0000 Hi, I was looking for examples on how to use fib6_lookup_rt and noticed there are comparisons between sa_len and AF_ flags in netflow.c if (nh->gw_sa.sa_len == AF_INET) if (nh->gw_sa.sa_len == AF_INET6) Are these typos for sa_family? https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n363 https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n437 Added in https://cgit.freebsd.org/src/commit/sys/netgraph/netflow/netflow.c?id=4e19e0d92ac6dfa5d2df6d525922f1e60487a9cc Thanks, Guy Yur