From owner-freebsd-arch@FreeBSD.ORG Wed Dec 24 07:23:10 2014 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C494DFA; Wed, 24 Dec 2014 07:23:10 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id 25248319F; Wed, 24 Dec 2014 07:23:10 +0000 (UTC) Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id E1362341F859; Tue, 23 Dec 2014 23:23:09 -0800 (PST) Message-ID: <549A69E4.7020508@freebsd.org> Date: Tue, 23 Dec 2014 23:23:16 -0800 From: Alfred Perlstein Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Phil Shafer Subject: Re: XML Output: libxo - provide single API to output TXT, XML, JSON and HTML References: <201410210217.s9L2HECn097421@idle.juniper.net> <549A5D1E.7020700@freebsd.org> In-Reply-To: <549A5D1E.7020700@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcel Moolenaar , John-Mark Gurney , "Simon J. Gerraty" , arch@freebsd.org, Poul-Henning Kamp , freebsd-arch , Konstantin Belousov X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2014 07:23:10 -0000 I have a github branch where I've started to merge the netstat patch in. I'm not sure I'm going to finish this one, if someone wants to pick it up, send me a pull request. The patch's .rej files are checked in so that it's easy to merge via a side-by-side editor of the file and .rej file. https://github.com/splbio/freebsd/tree/ap_libxo_netstat https://github.com/splbio/freebsd/compare/ap_libxo_netstat?expand=1 -Alfred On 12/23/14 10:28 PM, Alfred Perlstein wrote: > Folks, > > I see libxo has landed in FreeBSD, but it appears that the userland > mods to the utilities never made it in? Is my assessment correct? > > /usr/src/usr.bin/netstat % find /usr/src/ | xargs grep LIBXO | grep -v > /usr/src/contrib/libxo | grep -v /usr/src/lib/libxo > /usr/src/usr.bin/xo/Makefile:LIBXO= ${.CURDIR:H:H}/contrib/libxo > /usr/src/usr.bin/xo/Makefile:.PATH: ${LIBXO}/xo > /usr/src/usr.bin/xo/Makefile:CFLAGS+=-I${LIBXO}/libxo > > The patches against netstat are stale and were never applied. I have > not tried other utilities. > > /usr/src/usr.bin/netstat % wc -l *.rej > 547 if.c.rej > 549 inet.c.rej > 236 inet6.c.rej > 96 main.c.rej > 68 mroute.c.rej > 39 netgraph.c.rej > 415 route.c.rej > 24 unix.c.rej > 1974 total > > /usr/src/usr.bin/netstat % ls -l *.rej > -rw-r--r-- 1 alfred wheel 17486 Dec 23 22:15 if.c.rej > -rw-r--r-- 1 alfred wheel 22687 Dec 23 22:15 inet.c.rej > -rw-r--r-- 1 alfred wheel 11111 Dec 23 22:15 inet6.c.rej > -rw-r--r-- 1 alfred wheel 2325 Dec 23 22:15 main.c.rej > -rw-r--r-- 1 alfred wheel 2989 Dec 23 22:15 mroute.c.rej > -rw-r--r-- 1 alfred wheel 945 Dec 23 22:15 netgraph.c.rej > -rw-r--r-- 1 alfred wheel 11785 Dec 23 22:15 route.c.rej > -rw-r--r-- 1 alfred wheel 821 Dec 23 22:15 unix.c.rej > > Ouch... > > Is this slated for being freshened up? > > As I recall the student who did the GSoC had most of the code ready to > commit, utilities included, however we as a group decided not to take > the student's code because Juniper was going to provide libxo AND port > a few basic utilities to use it. > > -Alfred > > On 10/20/14 7:17 PM, Phil Shafer wrote: >> Alfred Perlstein writes: >>> It's now been 2 months since the last discussion about this. >>> Where is the code from Juniper? >> Code's still in github, if you want to take a look. It's been >> pretty much done since the end of August: >> >> https://github.com/Juniper/libxo/graphs/contributors >> >> I've got patches to seven bsd utilities here: >> >> https://github.com/Juniper/libxo/tree/master/patches >> >> Docs are still here: >> >> http://juniper.github.io/libxo/libxo-manual.html >> >> but I've also written man pages as well (back in Sept). At this >> point, I think it's completed. I was tempted on the plane ride >> home last Thursday to add a flag for calling humanize_number(), but >> I resisted. >> >> Marcel's working to get it into freebsd. >> >> Thanks, >> Phil >> >