From owner-cvs-all@FreeBSD.ORG  Thu Mar 24 21:05:15 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 201B316A4CE; Thu, 24 Mar 2005 21:05:15 +0000 (GMT)
Received: from fafoe.narf.at (chello213047085026.6.14.vie.surfer.at
	[213.47.85.26])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BDB9A43D1D; Thu, 24 Mar 2005 21:05:14 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42])
	by fafoe.narf.at (Postfix) with ESMTP id 0575D3FA7;
	Thu, 24 Mar 2005 22:05:10 +0100 (CET)
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 04AFD112; Thu, 24 Mar 2005 22:05:08 +0100 (CET)
Date: Thu, 24 Mar 2005 22:05:08 +0100
From: Stefan Farfeleder <stefan@fafoe.narf.at>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20050324210504.GL46915@wombat.fafoe.narf.at>
References: <200503241751.j2OHpFQg063306@repoman.freebsd.org>
	<20050324200942.GK46915@wombat.fafoe.narf.at>
	<20050324201936.GA30850@odin.ac.hmc.edu> <200503241555.59177.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503241555.59177.jhb@FreeBSD.org>
User-Agent: Mutt/1.5.9i
cc: Brooks Davis <brooks@one-eyed-alien.net>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2005 21:05:15 -0000

On Thu, Mar 24, 2005 at 03:55:59PM -0500, John Baldwin wrote:
> On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote:
> > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote:
> > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote:
> > > > Prior to C99, I think #error wasn't specified.  C99 does specify it.
> > >
> > > C89/90 had #error too.
> >
> > I stand corrected.  Now that I think about it, all but the perverse
> > preprocessors would implement #error just by blowing up on an unknown
> > directive so even that isn't an issue.  In any case, I've made the
> > change and the new code is at least shorter.  It's really only there for
> > people mucking with kernel internals who should be able to figure out
> > what it means.
> 
> We could always just change CTASSERT() to use #error if that is better.

Unfortunately you can't use preprocessor directives in the replacement
list of a macro.

Stefan