Date: Wed, 27 Apr 2022 21:10:36 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Neel Chauhan <nc@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, dmenelkir@gmail.com Subject: Re: git: a1fa6d25cd6c - main - audio/strawberry: Add pkg-message.in Message-ID: <YmmxTA9nujb6rrEJ@FreeBSD.org> In-Reply-To: <2d47938774a229feab628ce010ca4fd5@FreeBSD.org> References: <202204261954.23QJsmW9038121@gitrepo.freebsd.org> <20220427090153.cent72zrnib6m5qr@aching.in.mat.cc> <2d47938774a229feab628ce010ca4fd5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 27, 2022 at 01:24:17PM -0700, Neel Chauhan wrote: > On 2022-04-27 02:01, Mathieu Arnold wrote: > > Why files/pkg-message.in and not simply pkg-message ? There is no > > replacement done in there, no need to have the file run through sed for > > replacements that are not there. > > It was done by the person who made the patch, for some reason they chose > to use pkg-message.in. It's your responsibility as a committer to review and brush up whatever patches you intend to commit. We should never blindly accept proposed changes and check them in verbatim. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YmmxTA9nujb6rrEJ>