From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Feb 15 12:50:13 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 279621065673 for ; Wed, 15 Feb 2012 12:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EBF3D8FC29 for ; Wed, 15 Feb 2012 12:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1FCoCaP057300 for ; Wed, 15 Feb 2012 12:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1FCoC0c057299; Wed, 15 Feb 2012 12:50:12 GMT (envelope-from gnats) Resent-Date: Wed, 15 Feb 2012 12:50:12 GMT Resent-Message-Id: <201202151250.q1FCoC0c057299@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrey Simonenko Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E12D106564A for ; Wed, 15 Feb 2012 12:47:29 +0000 (UTC) (envelope-from simon@comsys.ntu-kpi.kiev.ua) Received: from comsys.kpi.ua (comsys.kpi.ua [77.47.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id C0DE78FC16 for ; Wed, 15 Feb 2012 12:47:27 +0000 (UTC) Received: from pm513-1.comsys.kpi.ua ([10.18.52.101] helo=pm513-1.comsys.ntu-kpi.kiev.ua) by comsys.kpi.ua with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Rxe3j-0008CT-61 for FreeBSD-gnats-submit@freebsd.org; Wed, 15 Feb 2012 14:34:07 +0200 Received: by pm513-1.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1001) id BF7941CC36; Wed, 15 Feb 2012 14:34:07 +0200 (EET) Message-Id: <20120215123407.GA67226@pm513-1.comsys.ntu-kpi.kiev.ua> Date: Wed, 15 Feb 2012 14:34:07 +0200 From: Andrey Simonenko To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/165177: ports/net/smbldap-tools 0.9.7 smbldap-useradd does not set all Samba attributes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2012 12:50:13 -0000 >Number: 165177 >Category: ports >Synopsis: ports/net/smbldap-tools 0.9.7 smbldap-useradd does not set all Samba attributes >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 15 12:50:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Andrey Simonenko >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: >Description: The @adds array is declared as a local variable in one place in smbldap-useradd.pl, and later its value is checked outside of its declaration scope. As a result just added Samba user will not get some Samba attributes. If this change goes to smbldap-tools port, then please do not forget about ports/161967. >How-To-Repeat: >Fix: Apply this change to smbldap-tools sources or as a patch for the smbldap-tools port: --- smbldap-useradd.pl.orig 2011-09-05 18:53:02.000000000 +0300 +++ smbldap-useradd.pl 2012-01-31 11:33:20.000000000 +0200 @@ -598,7 +598,7 @@ $tmp = defined( $Options{'F'} ) ? $Options{'F'} : $config{userProfile}; my $valprofilepath = &subst_user( $tmp, $userName ); - my @adds = (); + @adds = (); if ($valhomedrive) { push( @adds, 'sambaHomeDrive' => $valhomedrive ); @@ -618,13 +618,12 @@ push( @adds, 'sambaLMPassword' => "XXX" ); push( @adds, 'sambaNTPassword' => "XXX" ); } -} - -if (@adds) { - my $modify = - $ldap_master->modify( "uid=$userName,$config{usersdn}", add => {@adds} ); + if (@adds) { + my $modify = + $ldap_master->modify( "uid=$userName,$config{usersdn}", add => {@adds} ); - $modify->code && die "failed to add entry: ", $modify->error; + $modify->code && die "failed to add entry: ", $modify->error; + } } # add AIX user >Release-Note: >Audit-Trail: >Unformatted: