From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 25 10:20:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 19A60C3A for ; Thu, 25 Apr 2013 10:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D9E9A1B78 for ; Thu, 25 Apr 2013 10:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3PAK0Li065385 for ; Thu, 25 Apr 2013 10:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3PAK0tG065384; Thu, 25 Apr 2013 10:20:00 GMT (envelope-from gnats) Resent-Date: Thu, 25 Apr 2013 10:20:00 GMT Resent-Message-Id: <201304251020.r3PAK0tG065384@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bogdan Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id ABB68BE1 for ; Thu, 25 Apr 2013 10:15:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 9D9AF1B3E for ; Thu, 25 Apr 2013 10:15:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3PAFFa1041471 for ; Thu, 25 Apr 2013 10:15:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r3PAFFel041470; Thu, 25 Apr 2013 10:15:15 GMT (envelope-from nobody) Message-Id: <201304251015.r3PAFFel041470@red.freebsd.org> Date: Thu, 25 Apr 2013 10:15:15 GMT From: Bogdan To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/178138: [patch] puppet - enable in freebsd service provider is broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 10:20:01 -0000 >Number: 178138 >Category: ports >Synopsis: [patch] puppet - enable in freebsd service provider is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 25 10:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Bogdan >Release: 9.1-RELEASE >Organization: >Environment: 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: see https://github.com/puppetlabs/puppet/pull/1527 for explanation and patch When puppet is asked to enable a service in rc.conf, it adds apache_enable_enable="YES" and it keeps saying that it changed 'enable' from false to true every run. >How-To-Repeat: create a manifest for a service that isn't in rc.conf with ensure => running and apply it. check rc.conf >Fix: The commit that fixes this upstream is here: https://github.com/puppetlabs/puppet/pull/1527/files Patch is attached. Note that there is a newer version of puppet out, not sure when it was released or if it contains this fix. Patch attached with submission follows: --- freebsd.rb.original 2013-04-24 09:40:57.000000000 +0200 +++ freebsd.rb.patched 2013-04-25 10:31:56.000000000 +0200 @@ -41,7 +41,7 @@ def rcvar_name name = self.rcvar[1] self.error("No rcvar name found in rcvar") if name.nil? - name = name.gsub!(/(.*)(_enable)?=(.*)/, '\1') + name = name.gsub!(/(.*?)(_enable)?=(.*)/, '\1') self.error("rcvar name is empty") if name.nil? self.debug("rcvar name is #{name}") name >Release-Note: >Audit-Trail: >Unformatted: