From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct 27 21:39:13 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E21D696A
 for <freebsd-bugs@FreeBSD.org>; Mon, 27 Oct 2014 21:39:13 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C9BEC8A1
 for <freebsd-bugs@FreeBSD.org>; Mon, 27 Oct 2014 21:39:13 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s9RLdD7s054744
 for <freebsd-bugs@FreeBSD.org>; Mon, 27 Oct 2014 21:39:13 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 194643] New: VFS vnode locking incorrect for non-lockmgr vnodes
Date: Mon, 27 Oct 2014 21:39:13 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: conrad.meyer@isilon.com
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-194643-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 21:39:14 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194643

            Bug ID: 194643
           Summary: VFS vnode locking incorrect for non-lockmgr vnodes
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: conrad.meyer@isilon.com

insmntque and probably other parts of VFS are broken for VFS that do not use
lockmgr.

E.g. insmntque_stddtr enters with the vnode locked exclusive, wipes out the
v_op table, and then calls vput() which uses VOP_ISLOCKED, VOP_LOCK,
VOP_UNLOCK.

For VFS where vop_lock1, vop_unlock, vop_islocked doesn't use lockmgr,
insmntque_stddtr leaks the original lock; then vput tries to upgrade via
dead_vnops. This is pretty bogus. Even for VFS that use lockmgr,
insmntque_stddtr doesn't reset v_vnlock to &v_lock; it should probably do this
(or just let vgone() do it).

Additionally, since vgonel() wipes out v_op with dead_vnops, anything else that
holds a vnode lock over vgone() is bogus. (But, not observably so for lockmgr-
/ v_lock-using VFS.)

-- 
You are receiving this mail because:
You are the assignee for the bug.