From owner-freebsd-ports Sun Jan 21 12:24:46 2001 Delivered-To: freebsd-ports@freebsd.org Received: from king1.vineyard.net (K1.VINEYARD.NET [204.17.195.90]) by hub.freebsd.org (Postfix) with ESMTP id 40F0A37B404; Sun, 21 Jan 2001 12:24:26 -0800 (PST) Received: (from mail@localhost) by king1.vineyard.net (8.9.3/8.9.0) id PAA86947; Sun, 21 Jan 2001 15:24:25 -0500 (EST) Received: from loopback(127.0.0.1) by K1.VINEYARD.NET via smap/slg (V2.0) id sma086910; Sun Jan 21 15:24:20 2001 Date: Sun, 21 Jan 2001 15:24:19 -0500 (EST) From: Josh Elsasser X-Sender: joshe@king1.vineyard.net To: Joe Clarke Cc: Yukihiro Nakai , green@FreeBSD.org, ports@FreeBSD.org Subject: Re: snes9x ports for 4.2-STABLE In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org It segfaulted for me too. But if I patch the original patch-af (not the one Yukihiro Nakai just sent) like so: --- /usr/ports/emulators/snes9x/files/patch-af Sat Jan 13 18:12:09 2001 +++ /home/joshe/tmp/snes9x/files/patch-af Sun Jan 21 14:59:44 2001 @@ -298,7 +298,7 @@ + return (-1); + } + report_id = 0; -+ reportlen = hid_report_size(rd, report_id, hid_input); ++ reportlen = hid_report_size(rd, hid_input, &report_id); + my_info->buf = (char *)malloc(reportlen); + if (my_info->buf == NULL) + err(1, "malloc"); Then it builds and runs fine. My gravis usb gamepad pro works great too, aside from the fact that the two extra buttons are unused. On Sun, 21 Jan 2001, Joe Clarke wrote: > After compiling with the new patch-af, it seg faults after reading in the > ROM. > > Joe Clarke > > -- > > Please use Reply-To: address for response. > > Joe Clarke, CCIE #5384 | | > Customer Support Engineer ||||| ||||| > Phone: +1 (919) 392-2867 ..:|||||||||::|||||||||:.. > Email: jclarke@cisco.com c i s c o S y s t e m s > > ---------------------------------------------------------------------------- > > > On Mon, 22 Jan 2001, Yukihiro Nakai wrote: > > > > > Hi, > > > > The files/patch-af in ports/emulators/snes9x mave usb support, > > it seems work on 5.0-current, but not on 4.2-STABLE. > > (I got many bug-report mails from users.) > > This is because the function argument is different between them. > > > > In /usr/include/libusb.h, > > > > 5.0-current: > > int hid_report_size __P((report_desc_t d, unsigned int id, enum hid_kind k)); > > > > 4.2-STABLE : > > int hid_report_size __P((report_desc_t d, enum hid_kind k, int *idp)); > > > > So this new patch-af that I append here is needed to compile snes9x > > on 4.2-STABLE. > > > > I will add 5.0 macros and commit this after some tests... > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message