From owner-cvs-all  Thu Sep 13 17:19:29 2001
Delivered-To: cvs-all@freebsd.org
Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id 40BC737B414; Thu, 13 Sep 2001 17:18:57 -0700 (PDT)
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id RAA66162;
	Thu, 13 Sep 2001 17:41:48 -0700 (PDT)
Date: Thu, 13 Sep 2001 17:41:47 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: Julian Elischer <julian@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_descrip.c
In-Reply-To: <20010914082156.F14345-100000@delplex.bde.org>
Message-ID: <Pine.BSF.4.21.0109131741050.64766-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

I did  this in several places to reduce diff size..
I expect that many will dissappear with time as we rework the places where
they are..


On Fri, 14 Sep 2001, Bruce Evans wrote:

> On Wed, 12 Sep 2001, Julian Elischer wrote:
> 
> > julian      2001/09/12 13:26:58 PDT
> >
> >   Modified files:
> >     sys/kern             kern_descrip.c
> >   Log:
> >   If an incoming struct proc could have been NULL before, tehn don't
> >   automatically change the code to add
> >
> >   struct proc *p = td->td_proc;
> >
> >   because now 'td' is probably capable of being NULL too.
> >   I expect to see more of this kind of error during the 'weeding'
> >   process. It's too easy to make. (junior hacker project.. look for these :-)
> >
> >   Submitted by:	mark Peek <mp@freebsd.org>
> >
> >   Revision  Changes    Path
> >   1.108     +6 -5      src/sys/kern/kern_descrip.c
> 
> "struct proc *p = td->td_proc;" is forbidden by style(9) anyway.
> 
> Initializations in declarations now tend to be not just style bugs but
> races, since the style bugs in the declarations aren't usually as bad
> as doing the locking in initializers.  Matt had to move a number of
> initializations into the code after "mtx_lock_(&Giant)".
> 
> Bruce
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message