From owner-cvs-all@FreeBSD.ORG  Fri Dec 26 10:26:47 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1562916A4CE; Fri, 26 Dec 2003 10:26:47 -0800 (PST)
Received: from green.bikeshed.org (green@localhost [127.0.0.1])
	by green.bikeshed.org (8.12.10/8.12.9) with ESMTP id hBQIQknU060684;
	Fri, 26 Dec 2003 13:26:46 -0500 (EST)
	(envelope-from green@green.bikeshed.org)
Received: from localhost (green@localhost)hBQIQkAX060681;
	Fri, 26 Dec 2003 13:26:46 -0500 (EST)
Message-Id: <200312261826.hBQIQkAX060681@green.bikeshed.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Sam Leffler <sam@errno.com>
In-Reply-To: Message from Sam Leffler <sam@errno.com> 
   of "Fri, 26 Dec 2003 10:25:07 PST." <200312261025.07395.sam@errno.com> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 26 Dec 2003 13:26:46 -0500
Sender: green@green.bikeshed.org
cc: Brian Feldman <green@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Dec 2003 18:26:47 -0000

Sam Leffler <sam@errno.com> wrote:
> On Friday 26 December 2003 10:09 am, Brian Feldman wrote:
> > green       2003/12/26 10:09:35 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/net              if.c
> >   Log:
> >   Don't truncate the interface name in ifunit().  It's now possible to
> > query "very long interface names", e.g.:
> >   ndis_atheros0: flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST>
> > mtu 1500
> 
> I'm not sure this works out well as I believe user-level apps like netstat 
> assume interface names are short max-lengthed strings.  I've been using the 
> ndis stuff (great work btw) and was thinking instead that it would be nice to 
> customize the device by specifying the name at config time.
> 
> I think you need to discuss changes like this before committing them.

They are still short max-length strings.  ifunit() wasn't accounting for the 
"dev/" it was appending when it searches for a given interface, so it was 
limiting things to IFNAMSIZE - 4 accidentally.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\