From owner-svn-src-head@freebsd.org Thu Sep 1 13:38:47 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E924BCACA8; Thu, 1 Sep 2016 13:38:47 +0000 (UTC) (envelope-from mizhka@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F87AB18; Thu, 1 Sep 2016 13:38:46 +0000 (UTC) (envelope-from mizhka@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u81Dckes085584; Thu, 1 Sep 2016 13:38:46 GMT (envelope-from mizhka@FreeBSD.org) Received: (from mizhka@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u81Dckc0085583; Thu, 1 Sep 2016 13:38:46 GMT (envelope-from mizhka@FreeBSD.org) Message-Id: <201609011338.u81Dckc0085583@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mizhka set sender to mizhka@FreeBSD.org using -f From: Michael Zhilin Date: Thu, 1 Sep 2016 13:38:46 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r305196 - head/sys/dev/bhnd/cores/pmu X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 13:38:47 -0000 Author: mizhka Date: Thu Sep 1 13:38:46 2016 New Revision: 305196 URL: https://svnweb.freebsd.org/changeset/base/305196 Log: [BHND/PMU] Correct shift of bits in BHND_PMU_SET_BITS macro The purpose of BHND_PMU_{GET,SET}_BITS macro is to transform values from/into register format. SET macro shifts value to left and applies filter mask. GET macro applies filter mask and then shifts value to right. Reviewed by: landonf, adrian (mentor) Approved by: adrian (mentor) Differential Revision: https://reviews.freebsd.org/D7721 Modified: head/sys/dev/bhnd/cores/pmu/bhnd_pmureg.h Modified: head/sys/dev/bhnd/cores/pmu/bhnd_pmureg.h ============================================================================== --- head/sys/dev/bhnd/cores/pmu/bhnd_pmureg.h Thu Sep 1 13:29:53 2016 (r305195) +++ head/sys/dev/bhnd/cores/pmu/bhnd_pmureg.h Thu Sep 1 13:38:46 2016 (r305196) @@ -30,7 +30,7 @@ #define BHND_PMU_GET_BITS(_value, _field) \ (((_value) & _field ## _MASK) >> _field ## _SHIFT) #define BHND_PMU_SET_BITS(_value, _field) \ - (((_value) & _field ## _MASK) >> _field ## _SHIFT) + (((_value) << _field ## _SHIFT) & _field ## _MASK) #define BHND_PMU_ILP_CLOCK 32000 /**< default ILP freq */ #define BHND_PMU_ALP_CLOCK 20000000 /**< default ALP freq */