Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 18 Apr 2015 07:02:30 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 199509] check_leftovers.sh hardcodes CCACHE_DIR
Message-ID:  <bug-199509-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199509

            Bug ID: 199509
           Summary: check_leftovers.sh hardcodes CCACHE_DIR
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: ngie@FreeBSD.org
                CC: freebsd-ports-bugs@FreeBSD.org

CCACHE_DIR can be tuned in bsd.port.mk, based on the value passed in on the
command-line/environment. It should be fixed to use the value determined in
bsd.port.mk like so, instead of hardcoding the assumption that it's either
$HOME/.ccache or /root/.ccache:

$ svn diff ./ports/Mk/Scripts/check_leftovers.sh
Index: ports/Mk/Scripts/check_leftovers.sh
===================================================================
--- ports/Mk/Scripts/check_leftovers.sh (revision 476341)
+++ ports/Mk/Scripts/check_leftovers.sh
(.../ports/Mk/Scripts/check_leftovers.sh)       (working copy)
@@ -40,6 +40,7 @@
 else
        LOCALBASE=$(make -C ${portdir} -VLOCALBASE)
 fi
+ccache_dir=$(make -C ${portsdir} -VCCACHE_DIR)
 homedirs=$(awk -F: -v users=$(make -C ${portdir} -V USERS|sed -e 's,
,|,g;/^$/d') 'users && $1 ~ users {print $9}' ${PORTSDIR}/UIDs|sort -u|sed -e
"s|/usr/local|${PREFIX}|")
 plistsub_sed=$(make -C ${portdir} -VPLIST_SUB_SED | /bin/sh
${PORTSDIR}/Mk/Scripts/plist_sub_sed_sort.sh)
 tmpplist=$(make -C ${portdir} -VTMPPLIST)
@@ -47,7 +48,7 @@
 while read modtype path extra; do
        # Ignore everything from these files/directories
        case "${path}" in
-               ${HOME:-/root}/.ccache/*|/root/.ccache/*|\
+               ${ccache_dir}|\
                /compat/linux/proc/*|\
                /dev/*|\
                /etc/make.conf.bak|\

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199509-13>