From owner-svn-src-all@freebsd.org Fri Jun 17 16:56:45 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 599E9A78223; Fri, 17 Jun 2016 16:56:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2DA061E9F; Fri, 17 Jun 2016 16:56:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 26DA91045; Fri, 17 Jun 2016 16:56:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id D26A9DB0D; Fri, 17 Jun 2016 16:56:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 4El52RSPkeoO; Fri, 17 Jun 2016 16:56:42 +0000 (UTC) Subject: Re: svn commit: r301959 - head/sys/kern DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 3F776DB07 To: Konstantin Belousov , Conrad Meyer References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <20160617061306.GS38613@kib.kiev.ua> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Fri, 17 Jun 2016 09:56:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 16:56:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX Content-Type: multipart/mixed; boundary="MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9" From: Bryan Drewery To: Konstantin Belousov , Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r301959 - head/sys/kern References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <20160617061306.GS38613@kib.kiev.ua> In-Reply-To: --MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/17/2016 9:51 AM, Bryan Drewery wrote: > On 6/16/2016 11:13 PM, Konstantin Belousov wrote: >> On Thu, Jun 16, 2016 at 10:17:19AM -0700, Conrad Meyer wrote: >>> style(9) nit: /* FALLTHROUGH */ >> >> FALLTHROUGH is only applicable when there are executable statements fo= r >> both cases, and first sequence of statements does not end in break. >> Look at the switch() example right after the FALLTHROUGH requirement >> in the style(9), which shows case '?'. >> >=20 > Yes the example shows code in both cases, but the text about it is more= > strict "Elements in a switch statement that cascade should have a > FALLTHROUGH comment." >=20 My personal opinion does agree with your interpretation. I think we should clarify style.9 about when to use FALLTHROUGH. --=20 Regards, Bryan Drewery --MKgwKcVqiIqqrf1iNTc2qvbH3MsFa3js9-- --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXZCvQAAoJEDXXcbtuRpfPLkYIAKSuGvE4HjTdSq7Xbh3DNH6p AzTLallgZF2NBKgYbkLSmrxLsNg2Nx7u0utcJ9AoHiftpd6nhJqQC5+Uu5j1XRaK T0f15uc14owJnWj4s4jGTVHzDzklHkbDqGq/GczDA9dVqmJyLqDTdyIT0eZjB+es bbGemsUUpigtTq9yGxMn0zA4o71lFCHQLMCKqce3/YABdQQHTX5S2jQEeAtKmeuT xdqh1KFADxPsTaMal9yscH3VEwQ7tq+MLXgxwvPwfw2H1ohUGPdLU/Zjw6R207xs 28mSuOTE8WYMvl7l5mSEzob/99CqmvIIiVpXB7X9chKv77vMmVn//KT05oeE3fE= =Sk26 -----END PGP SIGNATURE----- --PenS8IDv3O4uDII91gFuGAbi6G5xBv0sX--