From owner-svn-src-head@freebsd.org Sun Mar 12 04:36:17 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40448D0989F; Sun, 12 Mar 2017 04:36:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 133271F32; Sun, 12 Mar 2017 04:36:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by freefall.freebsd.org (Postfix, from userid 1235) id 531733DA2; Sun, 12 Mar 2017 04:36:16 +0000 (UTC) Date: Sun, 12 Mar 2017 05:36:16 +0100 From: Baptiste Daroussin To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Cc: "Bjoern A. Zeeb" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Li-Wen Hsu Subject: Re: svn commit: r308996 - head/lib/libfetch Message-ID: <20170312043615.ax5a6xtuf2zmebc2@ivaldir.net> References: <201611221330.uAMDU7fg052989@repo.freebsd.org> <77B1B45A-D837-4853-B1E9-958D3B0DD519@lists.zabbadoz.net> <867f468rx5.fsf@desk.des.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g2vx6qbgkf4owmri" Content-Disposition: inline In-Reply-To: <867f468rx5.fsf@desk.des.no> User-Agent: NeoMutt/20170225 (1.8.0) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 04:36:17 -0000 --g2vx6qbgkf4owmri Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 03, 2017 at 01:29:26PM +0100, Dag-Erling Sm=C3=B8rgrav wrote: > "Bjoern A. Zeeb" writes: > > Dag-Erling Sm=C3=B8rgrav writes: > >> + /* split address if necessary */ > >> + err =3D EAI_SYSTEM; > >> + if ((sep =3D strchr(addr, ':')) !=3D NULL) { > >> + len =3D snprintf(hbuf, sizeof(hbuf), > >> + "%.*s", (int)(sep - addr), addr); > > I believe this code is what broke > > fetch http://[::1]:6666/ > > just to give an example; and the printf traces will not reveal this > > but =E2=80=9Caddr=E2=80=9D at this point has no more addr:port in it gi= ven the > > function arguments, right? >=20 > I think you're right, I'll look into it. It means replacing strchr() > with a loop. Is there a ticket for this bug, and if not, could you > please open one? >=20 This causes breakage on the cluster for everything using libfetch: On the jenkins cluster we cannot run anymore fetch inside i386 chroots # chroot ufs fetch -v http://pkg.freebsd.org resolving server address: pkg.freebsd.org:80 fetch: http://pkg.freebsd.org: Non-recoverable resolver failure What is specific is the host only have ipv6 is amd64 and the chroot is i386 I can't figure out the issue can you have a look? Best regards, Bapt --g2vx6qbgkf4owmri Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAljE0DwACgkQY4mL3PG3 PloCVBAAqg1bx98kzoBl0nkt0kn5//jKwvw8y5IBVgqO6kmloihvoMItx3JGeGrr c2UQ9FXyaHI5zpyUBlp5hQnf7KrLKAoqjegqsqqf3maf6eJQBD8L2xfmys50fNjp 7E9xI7vQ3T8jB+CQS3t4oAXRiCGb9Ic3a8bN3vKubA3Ib4Ce4L89e0KHV3p8W3M/ vOJ+2ou9EA9n/2DRW5KcrVCjfdtN0KRf+Lz7zJ5trBJ45sjMPwUI8qDkjUakl+35 YllESg4YyorAyh4+2IVEJP1MBXMO25R5aqNgfGaEKAKc+Td2f5xDvZBDmMORAblY p7CQvF8kPCGLNN4SJm+5BQkKpPfT0GrUgK0mcS4oiVuCawxo5qXnKF2h5I4e5LwK 5UyuHxwm6wBFIu1Xg6MjDkPep7oABuHYmVHAWHmik2H2fm6Q3OnVe+VzUzwmQYh4 zn3oHU5WIssmDNtfkOCU4w5pS6NuoO1Iv+ZIGzOdcxodO/fRxhez7fxpMdQGqDBG 8791VAy56OsVj/qP/bEpHH+dsLc9cM1eyxDrkeFYbxFuG0sW+vrr99HZjDrym6Ru vIxfBHHi95IQN1VIc2VzhE+lcUEZVpuppGyk/VrLok2lBbi3NJOp/y6izmuXAFWH hkKl+uaN5ji4HcoztclHcGifjdB/bAh9z87KEhFHywIg4mYjfA8= =J3yS -----END PGP SIGNATURE----- --g2vx6qbgkf4owmri--