From owner-svn-src-projects@FreeBSD.ORG  Mon Jul  6 08:00:26 2009
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AFB7C1065670;
	Mon,  6 Jul 2009 08:00:26 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F0868FC1D;
	Mon,  6 Jul 2009 08:00:26 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n6680Qob072669;
	Mon, 6 Jul 2009 08:00:26 GMT (envelope-from imp@svn.freebsd.org)
Received: (from imp@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n6680QMn072666;
	Mon, 6 Jul 2009 08:00:26 GMT (envelope-from imp@svn.freebsd.org)
Message-Id: <200907060800.n6680QMn072666@svn.freebsd.org>
From: Warner Losh <imp@FreeBSD.org>
Date: Mon, 6 Jul 2009 08:00:26 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r195400 - projects/mips/sys/libkern
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2009 08:00:27 -0000

Author: imp
Date: Mon Jul  6 08:00:26 2009
New Revision: 195400
URL: http://svn.freebsd.org/changeset/base/195400

Log:
  Be more pedantic here.  If we're going to shift something
  sizeof(long)*8 / 2 bits, then we better make sure we're shifting a
  long that much, not an int.
  
  # I'm surprised this is code would have a bug this basic.

Modified:
  projects/mips/sys/libkern/qdivrem.c
  projects/mips/sys/libkern/quad.h

Modified: projects/mips/sys/libkern/qdivrem.c
==============================================================================
--- projects/mips/sys/libkern/qdivrem.c	Mon Jul  6 07:49:24 2009	(r195399)
+++ projects/mips/sys/libkern/qdivrem.c	Mon Jul  6 08:00:26 2009	(r195400)
@@ -41,7 +41,7 @@ __FBSDID("$FreeBSD$");
 
 #include <libkern/quad.h>
 
-#define	B	(1 << HALF_BITS)	/* digit base */
+#define	B	(1UL << HALF_BITS)	/* digit base */
 
 /* Combine two `digits' to make a single two-digit number. */
 #define	COMBINE(a, b) (((u_long)(a) << HALF_BITS) | (b))

Modified: projects/mips/sys/libkern/quad.h
==============================================================================
--- projects/mips/sys/libkern/quad.h	Mon Jul  6 07:49:24 2009	(r195399)
+++ projects/mips/sys/libkern/quad.h	Mon Jul  6 08:00:26 2009	(r195400)
@@ -94,7 +94,7 @@ union uu {
  * (sizeof(long)*CHAR_BIT/2).
  */
 #define	HHALF(x)	((x) >> HALF_BITS)
-#define	LHALF(x)	((x) & ((1 << HALF_BITS) - 1))
+#define	LHALF(x)	((x) & ((1UL << HALF_BITS) - 1))
 #define	LHUP(x)		((x) << HALF_BITS)
 
 typedef unsigned int	qshift_t;