From owner-svn-src-all@FreeBSD.ORG Wed Mar 24 21:13:05 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11495106566B; Wed, 24 Mar 2010 21:13:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D7C4B8FC19; Wed, 24 Mar 2010 21:13:04 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 703B346B37; Wed, 24 Mar 2010 17:13:04 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id A266D8A021; Wed, 24 Mar 2010 17:13:03 -0400 (EDT) From: John Baldwin To: "Bjoern A. Zeeb" Date: Wed, 24 Mar 2010 16:20:20 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003241921.o2OJLQTC090739@svn.freebsd.org> In-Reply-To: <201003241921.o2OJLQTC090739@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003241620.20516.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 24 Mar 2010 17:13:03 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205626 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 21:13:05 -0000 On Wednesday 24 March 2010 3:21:26 pm Bjoern A. Zeeb wrote: > Author: bz > Date: Wed Mar 24 19:21:26 2010 > New Revision: 205626 > URL: http://svn.freebsd.org/changeset/base/205626 > > Log: > Print the pointer to the lock with the panic message. The previous > panic: rw lock not unlocked > was not really helpful for debugging. Now one can at least call > show lock > form ddb to learn more about the lock. Hmm, for consistency you may wish to fix similar panic messages in sx_destroy() and mtx_destroy(). There are many, many other panic messages in mtx, sx, and rwlock that do not include the lock pointer (though many do include the file/line which is nearly as useful). -- John Baldwin