From owner-dev-commits-src-all@freebsd.org Wed Mar 3 14:06:17 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0610C56B6C5; Wed, 3 Mar 2021 14:06:17 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DrG4m6YkJz3nHB; Wed, 3 Mar 2021 14:06:16 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id CDE8F223BB; Wed, 3 Mar 2021 14:06:16 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id A1E0527C0054; Wed, 3 Mar 2021 09:06:16 -0500 (EST) Received: from imap38 ([10.202.2.88]) by compute3.internal (MEProxy); Wed, 03 Mar 2021 09:06:16 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtvddgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdluddtmdenucfjughrpefofgggkfgjfhffhffvufgtsehttdertder reejnecuhfhrohhmpedfuehrrghnughonhcuuegvrhhgrhgvnhdfuceosggurhgrghhonh eshfhrvggvuefuffdrohhrgheqnecuggftrfgrthhtvghrnhepjefhfedtuddtleegkeeg tdegjeekffdvjedttdehgffgveeugffgfeelvdeghffgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepsggurhgrghhonhdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidquddtgedvfeehkeeigedqudekuddtkeehuddqsggurh grghhonheppefhrhgvvgeuufffrdhorhhgsehimhgrphdrtggt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id F2CEFCA005D; Wed, 3 Mar 2021 09:06:15 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-206-g078a48fda5-fm-20210226.001-g078a48fd Mime-Version: 1.0 Message-Id: <14d09680-1036-4a7e-8a0e-c3063cac8bc9@www.fastmail.com> In-Reply-To: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> References: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> Date: Wed, 03 Mar 2021 08:05:56 -0600 From: "Brandon Bergren" To: rgrimes@FreeBSD.org Cc: "Ed Maste" , "Warner Losh" , "Nathan Whitehorn" , src-committers , "" , dev-commits-src-main@FreeBSD.org Subject: =?UTF-8?Q?Re:_git:_2c26d77d989a_-_main_-_Remove_/boot/efi_from_mtree, _mi?= =?UTF-8?Q?ssed_in_0b7472b3d8d2.?= Content-Type: text/plain X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 14:06:17 -0000 On Wed, Mar 3, 2021, at 6:53 AM, Rodney W. Grimes wrote: > What am I missing here? One place I am being told this is run in > an environment that may not even be an EFI booted system, and in > another place it is being used as a test if something is mounted > on it, which should only be true on an EFI booted system. That the script in question is a generic script that runs as part of bsdinstall on every platform and has to be universal. The actual *problem* here is that usr.sbin/bsdinstall/scripts/bootconfig has a default case that is *) die "Unsupported arch $(uname -m) for UEFI install" which then causes the main script to bail out, leaving the system in a half-installed state. If that had just been an exit 0 this would have never been a problem, I suppose. Before the original change that broke this, there was a check that the script was not running on powerpc or mips platforms before running the efi bits, but this got taken out. -- Brandon Bergren bdragon@FreeBSD.org