Date: Wed, 10 Aug 2016 18:57:42 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Emmanuel Vadot <manu@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419993 - in head: mail/libmapi net/nanomsg Message-ID: <fda2d72e-6032-241d-2d38-9039673653b4@FreeBSD.org> In-Reply-To: <201608100821.u7A8LJqp055282@repo.freebsd.org> References: <201608100821.u7A8LJqp055282@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/08/2016 6:21 PM, Emmanuel Vadot wrote:
> +.if ${PORT_OPTIONS:MDOCS}
> +CMAKE_ARGS+= -DCMAKE_INSTALL_MANDIR:STRING=man
> +.else
> +CMAKE_ARGS+= -DNN_ENABLE_DOC=OFF
> .endif
This block can/should be replaced with options helpers (placed under
DOCS_BUILD_DEPENDS):
DOCS_CMAKE_BOOL= NN_ENABLE_DOC
DOCS_CMAKE_ON= -DCMAKE_INSTALL_MANDIR:STRING=man
See Mk/bsd.options.mk for details.
Please test (poudriere) with/without DOCS option to confirm that their
cmake scripts accept -D${content}:BOOL=false (what Ports does) as well
as 'OFF' for their NN_ENABLE_DOC cmake option.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fda2d72e-6032-241d-2d38-9039673653b4>