From owner-cvs-usrbin Tue Jul 2 00:02:31 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA04496 for cvs-usrbin-outgoing; Tue, 2 Jul 1996 00:02:31 -0700 (PDT) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA03401; Mon, 1 Jul 1996 23:53:21 -0700 (PDT) Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id IAA04186; Tue, 2 Jul 1996 08:52:22 +0200 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id IAA26314; Tue, 2 Jul 1996 08:52:22 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.7.5/8.6.9) id IAA10225; Tue, 2 Jul 1996 08:39:46 +0200 (MET DST) From: J Wunsch Message-Id: <199607020639.IAA10225@uriah.heep.sax.de> Subject: Re: cvs commit: src/usr.bin/fetch main.c To: jmz@freefall.freebsd.org (Jean-Marc Zucconi) Date: Tue, 2 Jul 1996 08:39:46 +0200 (MET DST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199607020149.SAA09845@freefall.freebsd.org> from Jean-Marc Zucconi at "Jul 1, 96 06:49:49 pm" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Jean-Marc Zucconi wrote: > jmz 96/07/01 18:49:49 > > Modified: usr.bin/fetch main.c > Log: > Use read(fileno(fp), ...) instead of fread(..., fp) to avoid buffered input. I'm still against it, and i consider it bad style that you're committing something that has caused opposition in the mailing lists. You haven't even marked your change with /* XXX bogus */ as would be the least sign of warning. If all your concern is avoiding input buffering, why have you never considered doing The Right Thing and using setvbuf(3)? -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)