Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Jul 1996 08:39:46 +0200 (MET DST)
From:      J Wunsch <j@uriah.heep.sax.de>
To:        jmz@freefall.freebsd.org (Jean-Marc Zucconi)
Cc:        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org
Subject:   Re: cvs commit:  src/usr.bin/fetch main.c
Message-ID:  <199607020639.IAA10225@uriah.heep.sax.de>
In-Reply-To: <199607020149.SAA09845@freefall.freebsd.org> from Jean-Marc Zucconi at "Jul 1, 96 06:49:49 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
As Jean-Marc Zucconi wrote:
> jmz         96/07/01 18:49:49
> 
>   Modified:    usr.bin/fetch  main.c
>   Log:
>   Use read(fileno(fp), ...) instead of fread(..., fp) to avoid buffered input.

I'm still against it, and i consider it bad style that you're
committing something that has caused opposition in the mailing lists.

You haven't even marked your change with

	/* XXX bogus */

as would be the least sign of warning.

If all your concern is avoiding input buffering, why have you never
considered doing The Right Thing and using setvbuf(3)?

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607020639.IAA10225>