Date: Sat, 31 Oct 2020 15:37:30 -0500 From: "Brandon Bergren" <bdragon@FreeBSD.org> To: "Brandon Bergren" <bdragon@imap.cc>, "Mateusz Guzik" <mjguzik@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r367229_-_in_head/sys/contrib/openzfs:_include?= =?UTF-8?Q?/sys/zstd_module/zstd?= Message-ID: <ac03dc12-4bfa-43db-abbf-44da355823e2@www.fastmail.com> In-Reply-To: <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com> References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> <CAGudoHFXAiobCwFgiNUj9UNRShNO1FctjsfS5w8xaWc%2B--d-gg@mail.gmail.com> <d5618cc3-3b0c-4c39-909e-863bd2f30de3@www.fastmail.com> <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Yeah, that is what was happening. The minimal implementation needed for libsa was missing. On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: > Maybe this is it?: > > Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h > =================================================================== > --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision 367230) > +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (working copy) > @@ -188,6 +188,8 @@ > */ > #undef atomic_add_64 > #define atomic_add_64(ptr, val) *(ptr) += val > +#undef atomic_sub_64 > +#define atomic_sub_64(ptr, val) *(ptr) -= val > #endif /* !_STANDALONE */ > > #endif /* !_OPENSOLARIS_SYS_ATOMIC_H_ */ > > > Note that there is also another build failure in the tree at the moment. > > On Sat, Oct 31, 2020, at 3:25 PM, Brandon Bergren wrote: > > Actually, looking at it again, it looks like the spl header is doing it > > wrong and not providing a fallback for atomic_sub_64, it's just > > defining it to atomic_subtract_64 and assuming that exists. > > > > On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > > > Yep, jenkins told me. Working on it. > > > > > > On 10/31/20, Brandon Bergren <bdragon@freebsd.org> wrote: > > > > This doesn't compile on platforms such as powerpc without pulling in the > > > > opensolaris atomics header from the spl that does locking emulation of 64 > > > > bit atomics, as platforms that don't have native 64 bit atomics do not > > > > provide them in the system header. > > > > -- > Brandon Bergren > bdragon@imap.cc > -- Brandon Bergren bdragon@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac03dc12-4bfa-43db-abbf-44da355823e2>