From owner-freebsd-arch@FreeBSD.ORG  Sat Jun 14 15:44:55 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A7ADD37B401
	for <arch@FreeBSD.ORG>; Sat, 14 Jun 2003 15:44:55 -0700 (PDT)
Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net
	[66.199.86.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7AF6243FBD
	for <arch@FreeBSD.ORG>; Sat, 14 Jun 2003 15:44:54 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h5EMioXQ001133;
	Sat, 14 Jun 2003 15:44:51 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h5EMimuQ001132;
	Sat, 14 Jun 2003 15:44:48 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Date: Sat, 14 Jun 2003 15:44:48 -0700
From: David Schultz <das@FreeBSD.ORG>
To: Dag-Erling Smorgrav <des@ofug.org>
Message-ID: <20030614224448.GA1080@HAL9000.homeunix.com>
Mail-Followup-To: Dag-Erling Smorgrav <des@ofug.org>,
	arch@freebsd.org
References: <xzp1xxw65o7.fsf@flood.ping.uio.no>
	<20030614200407.GA31706@HAL9000.homeunix.com>
	<xzp4r2s47zn.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzp4r2s47zn.fsf@flood.ping.uio.no>
cc: arch@FreeBSD.ORG
Subject: Re: unbreaking alloca
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jun 2003 22:44:56 -0000

On Sun, Jun 15, 2003, Dag-Erling Smorgrav wrote:
> David Schultz <das@FreeBSD.ORG> writes:
> > alloca() is, by necessity, a compiler feature.  AFAIK, you
> > shouldn't need to #define alloca __builtin_alloca, since any
> > compiler should be providing it if it is supported at all.  I
> > think simply declaring it should be sufficient; at least this is
> > the case for gcc.
> 
> Not if you build with -fno-builtin or some other option that disables
> builtins.  This is precisely why -CURRENT is currently broken.

Bleh, I apologize.  I was reading:

	-#ifdef __GNUC__
	-#define        alloca(sz)      __builtin_alloca(sz)
	-#else
	-#error FreeBSD alloca support needed for this compiler
	-#endif

as:

	+#ifdef __GNUC__
	+#define        alloca(sz)      __builtin_alloca(sz)
	+#else
	+#error FreeBSD alloca support needed for this compiler
	+#endif

/me crawls back into his cave.