From owner-freebsd-current@FreeBSD.ORG Fri Jun 5 06:30:02 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9C8A1065670; Fri, 5 Jun 2009 06:30:02 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 4F3018FC13; Fri, 5 Jun 2009 06:30:01 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) DomainKey-Signature: a=rsa-sha1; q=dns; c=simple; s=one; d=codelabs.ru; h=Received:Date:From:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:Sender; b=Vm+WuY32gQFKLlEXyE+/Q31WPGDthy7bBNNIujOVB9S+qVBFgC003PGibGB6G4CcHCI0v2Z5a4/6fhYBVaFf8LViM1ssbwwUOU2Wh3EWd+Xf9WO9xQwpfU3sxOIpRjAS8JIz9hHTpCuKQ7/BK+J8tXsYJxHinEM/9hR1BqzNdR4=; Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1MCSwC-000BEk-2y; Fri, 05 Jun 2009 10:30:00 +0400 Date: Fri, 5 Jun 2009 10:29:56 +0400 From: Eygene Ryabinkin To: John Baldwin Message-ID: References: <20090602222445.2F6017302F@freebsd-current.sentex.ca> <20090603194453.GA43137@alchemy.franken.de> <200906040802.27057.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Er1qpsOqk0l6oMce" Content-Disposition: inline In-Reply-To: <200906040802.27057.jhb@freebsd.org> Sender: rea-fbsd@codelabs.ru Cc: kmacy@freebsd.org, Marius Strobl , freebsd-current@freebsd.org, rwatson@freebsd.org, FreeBSD Tinderbox , sparc64@freebsd.org, current@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: rea-fbsd@codelabs.ru List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 06:30:03 -0000 --Er1qpsOqk0l6oMce Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thu, Jun 04, 2009 at 08:02:25AM -0400, John Baldwin wrote: > On Wednesday 03 June 2009 11:26:17 pm Eygene Ryabinkin wrote: > > Yes, seems like so. John, may be we can eliminate the only reference to > > KTR_PERCPU from sys/sys/pcpu.h? Both 'struct pcpu' fields seem to be > > unused (grep'ped -CURRENT sources). > > Yes. Fine. Then the attached patch should remove the stuff. -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ # --Er1qpsOqk0l6oMce Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-pcpu.h-eliminate-dead-code-with-KTR_PERCPU.patch" Content-Transfer-Encoding: quoted-printable =46rom fdb33fbebb9470529fd7dea56905f0454ac53905 Mon Sep 17 00:00:00 2001 =46rom: Eygene Ryabinkin Date: Fri, 5 Jun 2009 10:25:52 +0400 Subject: [PATCH] pcpu.h: eliminate dead code with KTR_PERCPU As per words of John Baldwin, http://lists.freebsd.org/pipermail/freebsd-current/2009-June/007749.html and as discovered by grep'ping -CURRENT sources, KTR_PERCPU is not used anywhere and there is no intention to support it. Signed-off-by: Eygene Ryabinkin --- sys/sys/pcpu.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/sys/sys/pcpu.h b/sys/sys/pcpu.h index 98705eb..500657e 100644 --- a/sys/sys/pcpu.h +++ b/sys/sys/pcpu.h @@ -76,10 +76,6 @@ struct pcpu { cpumask_t pc_other_cpus; /* Mask of all other cpus */ SLIST_ENTRY(pcpu) pc_allcpu; struct lock_list_entry *pc_spinlocks; -#ifdef KTR_PERCPU - int pc_ktr_idx; /* Index into trace table */ - char *pc_ktr_buf; -#endif #ifdef KTR char pc_name[PCPU_NAME_LEN]; /* String name for KTR. */ #endif --=20 1.6.3.1 --Er1qpsOqk0l6oMce--