From owner-svn-src-all@freebsd.org  Mon Aug 31 14:09:20 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 976A73C23EB;
 Mon, 31 Aug 2020 14:09:20 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BgBsD1BwFz4YK1;
 Mon, 31 Aug 2020 14:09:19 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 07VE9C06033207;
 Mon, 31 Aug 2020 07:09:12 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 07VE9Ch9033206;
 Mon, 31 Aug 2020 07:09:12 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202008311409.07VE9Ch9033206@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r364321 - head/sbin/ipfw
In-Reply-To: <CAPyFy2C1F9J5o38RcZHm+tD7gXQKxugaPhOfyjOoKem2tKXY=Q@mail.gmail.com>
To: Ed Maste <emaste@freebsd.org>
Date: Mon, 31 Aug 2020 07:09:12 -0700 (PDT)
CC: "Rodney W. Grimes" <rgrimes@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 4BgBsD1BwFz4YK1
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2020 14:09:20 -0000

> Hrm, it seems this reply ended up in my spam folder; sorry for not
> replying until now.

lol Oh, bad filter :-)

> > >                       *strchr(timestr, '\n') = '\0';
> > >                       bprintf(bp, "%s ", timestr);
> >                                        ^ Isnt this the +1 space?
> >
> > >               } else {
> > > -                     bprintf(bp, "%*s", twidth, " ");
> > > +                     bprintf(bp, "%*s", twidth + 1, " ");
> >                                         ^missing from this string?
> 
> Inserting an extra space in the format string would also work, sure. I
> considered doing it that way but in the end decided it's not
> materially more clear one way or another, so used the patch as
> submitted.

For me the + 1 leads to a "why is this here", where as the space
in the format string clearly matches the other condition of the else.
Also + 1 causes a run time computation, the extra space does not.


-- 
Rod Grimes                                                 rgrimes@freebsd.org