From owner-svn-src-head@freebsd.org Wed May 9 21:05:52 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1FCFFCC4E3 for ; Wed, 9 May 2018 21:05:52 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3EC7A6EC80 for ; Wed, 9 May 2018 21:05:52 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: bf9ba917-53cc-11e8-96f1-bf4d417d1def X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id bf9ba917-53cc-11e8-96f1-bf4d417d1def; Wed, 09 May 2018 21:05:49 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w49L5h0J062032; Wed, 9 May 2018 15:05:43 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1525899943.35372.42.camel@freebsd.org> Subject: Re: svn commit: r333438 - head/sbin/geom/class/eli From: Ian Lepore To: Mariusz Zaborski , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 09 May 2018 15:05:43 -0600 In-Reply-To: <201805092051.w49KpGZm079239@repo.freebsd.org> References: <201805092051.w49KpGZm079239@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 21:05:52 -0000 On Wed, 2018-05-09 at 20:51 +0000, Mariusz Zaborski wrote: > Author: oshogbo > Date: Wed May  9 20:51:16 2018 > New Revision: 333438 > URL: https://svnweb.freebsd.org/changeset/base/333438 > > Log: >   Change option dry-run from 'n' to 'C' in geli attach command. >    >   'n' is used in other commands to define the key index. >   We should be consistent with that. >   'C' option is used by patch(1) to perform dryrun so lets use that. This seems like a dangerous change. Today I am begining to write new product image creation scripts that involve geli, and I'm going to do so under the assumption that the commands and arguments are not going to suddenly change their meaning on some future OS update. Hopefully the new meaning of -n implies an argument which is validated as being either 0 or 1, so that any existing scripts that contain -n to mean "dry run" will very likely fail the validation and not silently misbehave. At the very least, it seems like an entry in UPDATING is required. -- Ian