From owner-p4-projects  Sat Jul 27  6:16:11 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6490637B401; Sat, 27 Jul 2002 06:16:08 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1C46637B400
	for <perforce@freebsd.org>; Sat, 27 Jul 2002 06:16:08 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CDF2B43E4A
	for <perforce@freebsd.org>; Sat, 27 Jul 2002 06:16:07 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6RDG7JU054134
	for <perforce@freebsd.org>; Sat, 27 Jul 2002 06:16:07 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6RDG7AI054131
	for perforce@freebsd.org; Sat, 27 Jul 2002 06:16:07 -0700 (PDT)
Date: Sat, 27 Jul 2002 06:16:07 -0700 (PDT)
Message-Id: <200207271316.g6RDG7AI054131@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 14990 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14990

Change 14990 by rwatson@rwatson_tislabs on 2002/07/27 06:15:43

	Note that we need a seperate entry point for the F_SETFL fcntl,
	since we really want to authorize the delta not just the flags.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_descrip.c#18 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_descrip.c#18 (text+ko) ====

@@ -326,6 +326,11 @@
 				mode |= VAPPEND;
 			vn_lock((struct vnode *)fp->f_data, LK_EXCLUSIVE |
 			    LK_RETRY, td);
+			/*
+			 * XXX: A seperate entry point should be used here
+			 * to pass in both the old and the new flags,
+			 * with authorization performed only on the delta.
+			 */
 			error = mac_cred_check_open_vnode(td->td_ucred,
 			    (struct vnode *)fp->f_data, mode);
 			VOP_UNLOCK((struct vnode *)fp->f_data, 0, td);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message