From nobody Sat Nov 12 12:41:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N8Zvk4vGFz4ffRs; Sat, 12 Nov 2022 12:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N8Zvk18DXz3tmt; Sat, 12 Nov 2022 12:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668256914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BOHrhcTpUiDsbr+pou1Dq1jJH9FYB8ChJOOEjm6damk=; b=LfpgPO9k6Lnk+u7AQslMQxvYXg/soYQfB0rUxcBDdY6TXCypqHJdvjm8yQCvjsTyW1Z+IE dJkvisF4BOSI+u4FhsiSaJw9ambeU8a9TVJTI2tp9UK0ohv0iTPun2Hr0j4zD8cEOpbM8q 6zDsFB6oah8A2zAtuUPnSbJdZuvMubvsecd9dV6VBJN9KcUyRjyF9zixMUQqBdULevCUK0 PR1EoCAxNDnleViAsj6LHu9xGDqIs1lIuruunXuLZvz7LS+SBRpsnC4D6OPffviq+lOIcF 1i/8YW9t7ml0v4gWuO3mDxX2yBfxIDKNZKFS+baTbeRk3o7pjpE0ubKxQp30BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668256914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BOHrhcTpUiDsbr+pou1Dq1jJH9FYB8ChJOOEjm6damk=; b=fgM3mfHAxdKHJnLx5Tw/A6+yvWUfe2TaGzQIQhshVhBtQSNOrFxrKfk3TxOJBx0bwCU0Rh Lo5lg2v1ETyIaY/yf8L4EVZyrtf9IznJlt+HAEVsowF6+V9ICaNFwMC9EgN3IoJwIGmFqA c74ta/UCZqcDtqeNCkyToZsAXmo3eFlebiuSXImXnCK/3fmzInY7UXRmTXg8MulQFQllKR e+j3BPMCcxuOtUNExMU7F72wZjFWyMWWIZEfJJl/xUwlrdmuychBCZC82T4fc15QncT1S6 8f+lMtc51WlK39BoVNER5svRljRGSSHP+zwsM06dBzcssghYfcvnn4+S6+BDMg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668256914; a=rsa-sha256; cv=none; b=bJyzDPP0ROyeLnrmLC+4NIn1FBpzAWDYUxy6vYq516YIOV9qzClId9Zdc88+I8+1BHsCSJ 5pDdKEC5xSxjqV9Y15AonsVlJPsOo/xehXPEe//bNesqPnUUnEWOrXKaLRjOHsNZoQXy6r snDej/ISgLYObItUl/xUFDVVveHRm5eWhKkTK1LqmkQa0Jt4e5nXqCy4AQXnYWhSyWQKu1 q/3ROAALmdEYQEUb8CWtyo9KEooq/+mJPQxOhX0DlT0sBZGnAa5CPoA228Qpkdckr1nyg/ 9jjalJ1zE5nIoyY0UB77r7p5y0wYmfalD2q6vo9FZZ5dmX68AYvzERBhnklQRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N8Zvk0G1pzP8H; Sat, 12 Nov 2022 12:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2ACCfrQR055940; Sat, 12 Nov 2022 12:41:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2ACCfrvu055939; Sat, 12 Nov 2022 12:41:53 GMT (envelope-from git) Date: Sat, 12 Nov 2022 12:41:53 GMT Message-Id: <202211121241.2ACCfrvu055939@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: a41a9e01c3cd - stable/13 - uslcom(4): Clear stall at every open. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a41a9e01c3cde8962bc48299a4e6894ad31a38bf Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=a41a9e01c3cde8962bc48299a4e6894ad31a38bf commit a41a9e01c3cde8962bc48299a4e6894ad31a38bf Author: Hans Petter Selasky AuthorDate: 2022-10-05 14:45:21 +0000 Commit: Hans Petter Selasky CommitDate: 2022-11-12 12:00:16 +0000 uslcom(4): Clear stall at every open. To avoid data loss, make sure both the receive and transmit data toggles get reset, before trying to read or write any data. Sponsored by: NVIDIA Networking (cherry picked from commit 9e0edafe92ad9fc6745ee4c4c58e45a49b9e7ed1) --- sys/dev/usb/serial/uslcom.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sys/dev/usb/serial/uslcom.c b/sys/dev/usb/serial/uslcom.c index fec18d2a5631..891137175dcb 100644 --- a/sys/dev/usb/serial/uslcom.c +++ b/sys/dev/usb/serial/uslcom.c @@ -441,12 +441,6 @@ uslcom_attach(device_t dev) "error=%s\n", usbd_errstr(error)); goto detach; } - /* clear stall at first run */ - mtx_lock(&sc->sc_mtx); - usbd_xfer_set_stall(sc->sc_xfer[USLCOM_BULK_DT_WR]); - usbd_xfer_set_stall(sc->sc_xfer[USLCOM_BULK_DT_RD]); - mtx_unlock(&sc->sc_mtx); - sc->sc_partnum = uslcom_get_partnum(sc); error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc, @@ -516,6 +510,10 @@ uslcom_cfg_open(struct ucom_softc *ucom) DPRINTF("UART enable failed (ignored)\n"); } + /* clear stall */ + usbd_xfer_set_stall(sc->sc_xfer[USLCOM_BULK_DT_WR]); + usbd_xfer_set_stall(sc->sc_xfer[USLCOM_BULK_DT_RD]); + /* start polling status */ uslcom_watchdog(sc); }