From owner-freebsd-ports@FreeBSD.ORG Wed May 6 04:11:12 2009 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0583C1065673; Wed, 6 May 2009 04:11:12 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id D2FC68FC16; Wed, 6 May 2009 04:11:11 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.3/8.14.3) with ESMTP id n464BAO0041400; Tue, 5 May 2009 21:11:10 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.3/8.14.2/Submit) id n464BADS041399; Tue, 5 May 2009 21:11:10 -0700 (PDT) (envelope-from obrien) Date: Tue, 5 May 2009 21:11:10 -0700 From: "David O'Brien" To: "Philip M. Gollucci" Message-ID: <20090506041109.GB41229@dragon.NUXI.org> References: <49FB64CC.9030002@ridecharge.com> <20090504062155.GC43414@dragon.NUXI.org> <49FF8315.2070906@ridecharge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49FF8315.2070906@ridecharge.com> X-Operating-System: FreeBSD 8.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: "ports@FreeBSD.org" , "Philip M. Gollucci" , "gabor@FreeBSD.org" , "portmgr@FreeBSD.org" Subject: Re: MAKE_JOBS_UNSAFE+= shells/bash, textproc/ispell X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 May 2009 04:11:12 -0000 On Mon, May 04, 2009 at 08:06:45PM -0400, Philip M. Gollucci wrote: > David O'Brien wrote: >> On Fri, May 01, 2009 at 05:08:28PM -0400, Philip M. Gollucci wrote: >>> shells/bash is only failing about 2.5/8 >>> textproc/ispell is only about 2/8 >> Hi Philip, >> I'm sorry - I really don't know what this means. > > The recent parrallel make functionality pav@ added to MK/bsd.port.mk. > shells/bash is not parallel safe as it is. > Setting > MAKE_JOBS_UNSAFE=yes > notes this and allows you to set FORCE_MAKE_JOBS=yes in /etc/make.conf > and not have shells/bash fail. I was under the impression that MAKE_JOBS_UNSAFE was the default and one had to explicity put MAKE_JOBS_SAFE=yes in a port. Pav Lucistnik writes: As you might have noticed on the commit list, I have committed support for internally parallelized builds, ie. setting -jX make argument. It's opt-in, so if you want your port to make use of this feature, you will need to put MAKE_JOBS_SAFE=yes into it's Makefile. I will add MAKE_JOBS_UNSAFE=yes to the port. > I was saying that it really is a RACE condition, and not just buggy make vs > gmake code i.e. (cd x; do y) .. It only doesn't work 2.5 out of every 8 > times. Ah! -- -- David (obrien@FreeBSD.org)