From nobody Sat Nov 12 17:42:54 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N8jbK0vPyz4d7x6; Sat, 12 Nov 2022 17:43:09 +0000 (UTC) (envelope-from freebsd@oldach.net) Received: from nuc.oldach.net (hmo.in-vpn.de [IPv6:2001:67c:1407:60::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "nuc.oldach.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N8jbH2SmHz4Qb8; Sat, 12 Nov 2022 17:43:06 +0000 (UTC) (envelope-from freebsd@oldach.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of freebsd@oldach.net designates 2001:67c:1407:60::1 as permitted sender) smtp.mailfrom=freebsd@oldach.net; dmarc=none Received: from nuc.oldach.net (localhost [127.0.0.1]) by nuc.oldach.net (8.17.1/8.17.1/hmo04jun22) with ESMTPS id 2ACHgsgi040471 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 12 Nov 2022 18:42:54 +0100 (CET) (envelope-from freebsd@oldach.net) Received: (from hmo@localhost) by nuc.oldach.net (8.17.1/8.17.1/hmo04jun22/Submit) id 2ACHgstj040466; Sat, 12 Nov 2022 18:42:54 +0100 (CET) (envelope-from freebsd@oldach.net) Message-Id: <202211121742.2ACHgstj040466@nuc.oldach.net> Subject: Re: git: 5ae69e2f10da - stable/13 - Import the WireGuard driver from zx2c4.com. In-Reply-To: <202211112204.2ABM4KYW005382@gitrepo.freebsd.org> from John Baldwin at "11 Nov 2022 22:04:20" To: jhb@FreeBSD.org (John Baldwin) Date: Sat, 12 Nov 2022 18:42:54 +0100 (CET) Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: freebsd@oldach.net (Helge Oldach) X-No-Archive: Yes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: inspected by milter-greylist-4.6.4 (nuc.oldach.net [0.0.0.0]); Sat, 12 Nov 2022 18:42:54 +0100 (CET) for IP:127.0.0.1 DOMAIN:localhost HELO:nuc.oldach.net FROM:freebsd@oldach.net RCPT: X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.27 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-0.97)[-0.973]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; FROM_NO_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-branches@FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ASN(0.00)[asn:29670, ipnet:2001:67c:1400::/45, country:DE]; RCPT_COUNT_THREE(0.00)[4]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[oldach.net]; TO_DN_NONE(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4N8jbH2SmHz4Qb8 X-ThisMailContainsUnwantedMimeParts: N John Baldwin wrote on Fri, 11 Nov 2022 23:04:20 +0100 (CET): > The branch stable/13 has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5ae69e2f10dacd750b0f0e9284fefcbe97eb0476 > > commit 5ae69e2f10dacd750b0f0e9284fefcbe97eb0476 > Author: John Baldwin > AuthorDate: 2022-10-28 20:36:12 +0000 > Commit: John Baldwin > CommitDate: 2022-11-11 21:44:11 +0000 > > Import the WireGuard driver from zx2c4.com. Is perhaps an #include missing in if_wg.c? I'm getting below error on stable/13-n252920-0baacb12181. After manually adding said header include, it compiles cleanly. --- modules-all --- --- if_wg.o --- /usr/src/sys/dev/wg/if_wg.c:2741:17: error: implicit declaration of function 'crhold' is invalid in C99 [-Werror,-Wimplicit-function-declaration] sc->sc_ucred = crhold(curthread->td_ucred); ^ /usr/src/sys/dev/wg/if_wg.c:2741:33: error: incomplete definition of type 'struct thread' sc->sc_ucred = crhold(curthread->td_ucred); ~~~~~~~~~^ /usr/src/sys/sys/sockbuf.h:73:8: note: forward declaration of 'struct thread' struct thread; ^ /usr/src/sys/dev/wg/if_wg.c:2742:37: error: incomplete definition of type 'struct thread' sc->sc_socket.so_fibnum = curthread->td_proc->p_fibnum; ~~~~~~~~~^ /usr/src/sys/sys/sockbuf.h:73:8: note: forward declaration of 'struct thread' struct thread; ^ /usr/src/sys/dev/wg/if_wg.c:2869:3: error: implicit declaration of function 'crfree' is invalid in C99 [-Werror,-Wimplicit-function-declaration] crfree(cred); ^ /usr/src/sys/dev/wg/if_wg.c:2945:66: error: incomplete definition of type 'struct ucred' if (!(sc->sc_flags & WGF_DYING) && sc->sc_ucred && sc->sc_ucred->cr_prison == pr) { ~~~~~~~~~~~~^ /usr/src/sys/sys/systm.h:131:8: note: forward declaration of 'struct ucred' struct ucred; ^ /usr/src/sys/dev/wg/if_wg.c:2951:4: error: implicit declaration of function 'crfree' is invalid in C99 [-Werror,-Wimplicit-function-declaration] crfree(cred); ^ 6 errors generated. *** [modules-all] Error code 6 make[2]: stopped in /usr/obj/usr/src/amd64.amd64/sys/HMO Kind regards Helge