From nobody Wed Aug 6 06:04:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bxfs361D8z64F9X; Wed, 06 Aug 2025 06:04:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bxfs340HZz3vTr; Wed, 06 Aug 2025 06:04:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754460295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p0tpkq+jq6d/Bka+y303I+UG+s64JGNmxG800yTxX6M=; b=NeXk4JXj6kYtcIIDxSjQu0pnJvhNYao3FuzjmmzZ5Buxc71yrUPEL/IcE8O8ixQac2GMZO Y+7icL4dZsM7tDVs1nrJjdCLzPiN1L5wczGNTiGv0eTr/OzkCTdNjZ0sex1p4bCB2g6PVJ hptCqPwpNYTUJkF8Z2RIF7mdPLs4KTNGyYUxfEZLlsT25PSR9O+CVE/3CS+pjmRBhdMEuq l2ICiRH7WVZQnAv7AFjmpfpdZBCfxHYQo0U7v6dhUEH7X2EX1VjQgHytGS9bBtB2Abj7f0 AnXL/Lwyjejxdpq7hG/QQlgAhVHmc84b2gK95uKzvNUc7bgD5l6GLuxc1kV52Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754460295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p0tpkq+jq6d/Bka+y303I+UG+s64JGNmxG800yTxX6M=; b=taSLzqYhIoyoMHdRRK1l5lFq2RvRgR+kOtei7VYR8xv46RHVnmPUoytyY/oJn2gugMykSH IS1xRVWYNGfan9HdoLGqiGqInPhEi4tjfZEhtGl/DmHczPQPLP61xvZ9JPbIHKzjk+UJEp 6I2tCq0L13SzT2EgwgUqI/xhWyaqElUaora06cAgD0QQOhH3RljMyQHOu+xOuOB3uijt4c XVIfe4nSkMq89Ml/EbTpxwPqi9otutqB+EOMLPjIZ8W+3QzltXx8GWOMrDnobq7G+ji2Jo 4xdGdjknt/vrphQ294lWLHKf+7RS8/qcBzYyWYkcaMZvEE2EA+CInZhPozyC5Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754460295; a=rsa-sha256; cv=none; b=AUtbb121C5QHWNC0cHCc7JtMXjESETRCjzBNqH6LVLCQkIH+Lw0oq9B1NP2Q7b5BHVCURY nMciEwXsx+UTaUqLahaUsI9f/O51J5ocO7mgo7FU/cCS0Og4VbSw6PpoYituSYcJFwdtcA KQJE9qsvOe+jPngeYeTlBfdF+W06/f9r4JUD8APxDw6nA7oorT6YDulwAzFy4tSGJsla/i UnoNEYZhL1FibYkKmC+DEcQkwr+co6XmrRiDiF0G1XlBY16iCifTmeqzHQC5twApah4dJI g0M6q7s8v/0I/Bn6TVXeXvqFDVn1/efWivo/iuJrUonV7RfOQdLPN9mtqiHrUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bxfs33N9wz17nN; Wed, 06 Aug 2025 06:04:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57664toO077695; Wed, 6 Aug 2025 06:04:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57664tBg077690; Wed, 6 Aug 2025 06:04:55 GMT (envelope-from git) Date: Wed, 6 Aug 2025 06:04:55 GMT Message-Id: <202508060604.57664tBg077690@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: 706291eddb45 - stable/13 - mmc_da: garbage-collect sdda_get_max_data List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 706291eddb45a9afd8e690dc8d7e2c8d6bad6084 Auto-Submitted: auto-generated The branch stable/13 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=706291eddb45a9afd8e690dc8d7e2c8d6bad6084 commit 706291eddb45a9afd8e690dc8d7e2c8d6bad6084 Author: Andriy Gapon AuthorDate: 2025-07-04 07:53:11 +0000 Commit: Andriy Gapon CommitDate: 2025-08-06 06:04:32 +0000 mmc_da: garbage-collect sdda_get_max_data The function is unused since 5aedb8b1d4a6. For information, in MMC CAM both XPT_GET_TRAN_SETTINGS and XPT_PATH_INQ obtain data using MMC_SIM_GET_TRAN_SETTINGS. So, "overlapping" information like ccb_trans_settings_mmc::host_max_data and ccb_pathinq::maxio is derived from the same source. That's why sdda_get_max_data was redundant. Reported by: bz (cherry picked from commit ad0c3859a9184036484c0cd63d7260a4a3d1ad2d) --- sys/cam/mmc/mmc_da.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c index 6ea05863d646..8f9646f7b98f 100644 --- a/sys/cam/mmc/mmc_da.c +++ b/sys/cam/mmc/mmc_da.c @@ -1199,27 +1199,6 @@ sdda_get_host_caps(struct cam_periph *periph, union ccb *ccb) return (cts->host_caps); } -static uint32_t -sdda_get_max_data(struct cam_periph *periph, union ccb *ccb) -{ - struct ccb_trans_settings_mmc *cts; - - cts = &ccb->cts.proto_specific.mmc; - memset(cts, 0, sizeof(struct ccb_trans_settings_mmc)); - - ccb->ccb_h.func_code = XPT_GET_TRAN_SETTINGS; - ccb->ccb_h.flags = CAM_DIR_NONE; - ccb->ccb_h.retry_count = 0; - ccb->ccb_h.timeout = 100; - ccb->ccb_h.cbfcnp = NULL; - xpt_action(ccb); - - if (ccb->ccb_h.status != CAM_REQ_CMP) - panic("Cannot get host max data"); - KASSERT(cts->host_max_data != 0, ("host_max_data == 0?!")); - return (cts->host_max_data); -} - static void sdda_start_init(void *context, union ccb *start_ccb) {