From owner-freebsd-current@FreeBSD.ORG  Mon Apr 26 15:18:14 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5FC611065676;
	Mon, 26 Apr 2010 15:18:14 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 1B8D88FC13;
	Mon, 26 Apr 2010 15:18:13 +0000 (UTC)
Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57])
	(authenticated bits=0)
	by pooker.samsco.org (8.14.3/8.14.3) with ESMTP id o3QFI7kJ098383;
	Mon, 26 Apr 2010 09:18:07 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Mime-Version: 1.0 (Apple Message framework v1078)
Content-Type: text/plain; charset=us-ascii
From: Scott Long <scottl@samsco.org>
In-Reply-To: <4BD58C35.2010305@FreeBSD.org>
Date: Mon, 26 Apr 2010 09:18:07 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <5446E60D-0EE8-403E-A409-071ECE2EC534@samsco.org>
References: <4BD06BD9.6030401@FreeBSD.org>
	<20100424193034.GA9853@alchemy.franken.de>
	<4BD58C35.2010305@FreeBSD.org>
To: Alexander Motin <mav@freebsd.org>
X-Mailer: Apple Mail (2.1078)
X-Spam-Status: No, score=-1.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD
	autolearn=unavailable version=3.3.0
X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org
Cc: freebsd-geom@freebsd.org, FreeBSD-Current <freebsd-current@freebsd.org>,
	Marius Strobl <marius@alchemy.franken.de>
Subject: Re: Switchover to CAM ATA?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2010 15:18:14 -0000

On Apr 26, 2010, at 6:51 AM, Alexander Motin wrote:
> Marius Strobl wrote:
>> As noted earlier, pc98 and sparc64 need ada(4)/CAM ATA to perform
>> geometry translation as done by ad_firmware_geom_adjust() for ad(4),
>> which the following patch hooks up to both:
>> http://people.freebsd.org/~marius/ata_disk_firmware_geom_adjust.diff
>> You preferred to implement such functionality via XPT_CALC_GEOMETRY
>> though (I'm still not convinced that it makes sense to put this
>> functionality into every ATA SIM the same way it is done for SCSI
>> rather than letting ada(4) handle it the same way for all SIMs
>> however). Have you looked into implementing XPT_CALC_GEOMETRY for
>> ATA CAM or is it okay to commit the above patch?
>=20
> Sorry, I have forgotten about this.
>=20
> I don't have better idea. For ATA translation seems indeed more
> platform- then controller-specific. May be I would just preferred to =
see
> this hack to be done inside XPT_CALC_GEOMETRY handler, as it is done =
now
> for PC98 SCSI. But looking that whole this topic is quite crappy and
> hopefully going to die sometimes, I won't argue much against =
committing
> this as-is for now.

Put this into XPT_CALC_GEOMETRY.  There's no point in perpetuating the =
mistakes of the ata driver.
Give me a day or two to think of a reasonable way to do it right.

Scott