From owner-svn-src-all@FreeBSD.ORG  Tue Nov 25 09:36:55 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A5A2D941;
 Tue, 25 Nov 2014 09:36:55 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 66477BEF;
 Tue, 25 Nov 2014 09:36:55 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 4C4EDAC2E;
 Tue, 25 Nov 2014 09:36:54 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 70392127F; Tue, 25 Nov 2014 10:36:51 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Ermal LuXXi <eri@FreeBSD.org>
Subject: Re: svn commit: r274709 - head/sys/netpfil/pf
References: <201411191331.sAJDV9bH092190@svn.freebsd.org>
Date: Tue, 25 Nov 2014 10:36:51 +0100
In-Reply-To: <201411191331.sAJDV9bH092190@svn.freebsd.org> (Ermal LuXXi's
 message of "Wed, 19 Nov 2014 13:31:09 +0000 (UTC)")
Message-ID: <86tx1nvcy4.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 09:36:55 -0000

Ermal LuXXi <eri@FreeBSD.org> writes:
> Log:
>   pf(4) needs to have a correct checksum during its processing.
>   Calculate checksums for the IPv6 path when needed before
>   delving into pf(4) code as required.
>=20=20=20
>   PR:     172648, 179392
>   Reviewed by:    glebius@
>   Approved by:    gnn@
>   Obtained from:  pfSense
>   MFC after:      1 week
>   Sponsored by:   Netgate

This is wrong, and causes a panic with some network adapters (vtnet, for
one).  It is closely related to 192013 and should not have been
committed without consulting me first.  Please revert, or just #if 0 out
the entire block since the old code is even more wrong than your
version.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no