From owner-freebsd-audit Wed Feb 27 13:50:33 2002 Delivered-To: freebsd-audit@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 7CEAB37B41B for ; Wed, 27 Feb 2002 13:50:17 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g1RLo1D85629; Wed, 27 Feb 2002 13:50:01 -0800 (PST) (envelope-from obrien) Date: Wed, 27 Feb 2002 13:50:00 -0800 From: "David O'Brien" To: Mark Murray Cc: audit@freebsd.org Subject: Re: lib/csu cleanup Message-ID: <20020227135000.A85486@dragon.nuxi.com> Reply-To: obrien@freebsd.org References: <200201172146.g0HLkft13995@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200201172146.g0HLkft13995@grimreaper.grondar.org>; from mark@grondar.za on Thu, Jan 17, 2002 at 09:46:41PM +0000 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jan 17, 2002 at 09:46:41PM +0000, Mark Murray wrote: > Index: alpha/crt1.c > =================================================================== > RCS file: /home/ncvs/src/lib/csu/alpha/crt1.c,v > retrieving revision 1.10 > diff -u -d -r1.10 crt1.c > --- alpha/crt1.c 26 Oct 2001 06:45:10 -0000 1.10 > +++ alpha/crt1.c 17 Jan 2002 21:11:52 -0000 ... > /* > * NOTE: Leave the RCS ID _after_ __start(), in case it gets placed in .text. > */ > -#ifndef lint > -static const char rcsid[] = > - "$FreeBSD: src/lib/csu/alpha/crt1.c,v 1.10 2001/10/26 06:45:10 obrien Exp $"; > -#endif > + > +__FBSDID("$FreeBSD: src/lib/csu/alpha/crt1.c,v 1.10 2001/10/26 06:45:10 obrien Exp $"); I am not comfortable with this change. __FBSDID has several ways of implimenting its functionality. In crt*.0 we must be careful what goes into the files, how, and where. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message