From owner-freebsd-hackers Tue Jan 21 21:26:38 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 584AF37B401 for ; Tue, 21 Jan 2003 21:26:37 -0800 (PST) Received: from obsecurity.dyndns.org (adsl-64-169-106-48.dsl.lsan03.pacbell.net [64.169.106.48]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA56B43F18 for ; Tue, 21 Jan 2003 21:26:36 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 4435266B3A; Tue, 21 Jan 2003 21:26:36 -0800 (PST) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 203401658; Tue, 21 Jan 2003 21:26:36 -0800 (PST) Date: Tue, 21 Jan 2003 21:26:36 -0800 From: Kris Kennaway To: Matthew Dillon Cc: Kris Kennaway , hackers@FreeBSD.ORG, Hiten Pandya Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel Message-ID: <20030122052636.GA25050@rot13.obsecurity.org> References: <200301220325.h0M3PiNt099890@apollo.backplane.com> <20030121195803.A32701@citusc.usc.edu> <200301220402.h0M42xBo000193@apollo.backplane.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline In-Reply-To: <200301220402.h0M42xBo000193@apollo.backplane.com> User-Agent: Mutt/1.4i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 21, 2003 at 08:02:59PM -0800, Matthew Dillon wrote: > :You shouldn't modify vendor code for minor purposes. > : > :Kris >=20 > The vendor code in question has been modified *extensively* since > it was imported, (and of course I would give Darren a head's up in > regards to ipfilter). Unless you have a more specific reason I don't > really think a general blanket statement is sufficient reason to not > do the commit, at least not in this case. I think you need to respect vendor code, and the FreeBSD committers who maintain it. Kris --/04w6evG8XlLl3ft Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+LiuLWry0BWjoQKURAj7lAKDEAQFmznNxGSP+5jvKIDkrCD7l5QCgwhI1 qr8sLV+sFKnoasGUe1TCeyQ= =iQqz -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message