From nobody Tue Apr 14 22:13:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwJTF1sSCz6ZWYt; Tue, 14 Apr 2026 22:13:53 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwJTF0lDxz3L5Z; Tue, 14 Apr 2026 22:13:53 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776204833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WFTcVDWxWQE8dRqMLynG46Rc+AU+JjhZHGyQlilG7ls=; b=X4MIFJAkb85H254g17Zh7/XJWWkLnHuCdjBB7h+f+9zUcOjpsTvcEmvDhnxEpndvky0UQ0 9MxdHQBo19HudFoN4lkBZp2X8dWLq3wWUKfHl7qex+8Vx7aSO5rJDKvef0LDo5juIOG9mn wq4+iPW1r8lGCpRTXjO6wZaq0kMJK+bcFiL/+un7fUiZFqBl8LUXgjgJGpaTkwYK0gE0DF 5ljhGVuncqj+mtgg8BvczNyk3MslijXP5jMKtH0i7JisHbenFadhI14uiWIgoJkAUI9suI iDM4bzivAVL7y4QLxXWigEEBkV06IRM4a49J15gB+XkHpkXtAqrr1meNlAYpsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776204833; a=rsa-sha256; cv=none; b=aRDvyAUn1GqjjuZTohvtl153aYcMqphKHOHg8E/lISP4VWu0bohEG3Fm0S47xHowvMBymy BdZGGe5HJc2hVhYLrRfjz27nndxVHTpKx/C9gfXJCwL/F6a/roiCi0Hqc7zHgEok2MHSSz 9g/jfNpqdK+x2OJr3KYqewdbigfHc2uvVMrY+GMEg0/Dq2X53z6g0fSF4pVCyHWBdeyfTj TTff84yV1rFUGvkwHFbbWC4wQYv558zJ4wcIYRNddyGK8IwCz2mXtxITwHb2jg2JJAN3/k V2wekofDjlrkDbcn70Lsq3V8yYJI0V9Trj30IW6my/o4gyQzpNOmNeDWETFDUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776204833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WFTcVDWxWQE8dRqMLynG46Rc+AU+JjhZHGyQlilG7ls=; b=lj9Re5Z+G6TohwO/4j7i/bhozxrzccB6cj1qCpD8GQDa3n5D9VrGa4bQSFYN9s5bxo6EEk 8TuPk+pLXOomChaSnlrh5OWyGU0kZxaOpAhA4+v9+mrficjFWcaDnSy16EK+fxAee9SwQT ihVU/wPZHukrKc9p2Z62Rio9F0asfh5ZVgBJiG2tmIrTMkO9bZQ+rq1lpI4ldLdpOIvNWy u2AidHxdRBi4oAyTgLhIyMd5XPCeoeh83hI2HYwBmcuW5gCiL/RMMrTSWFAMk9vA81mrDz V5hwhzsI/mIglJJLGL17+isdD/SNVas4t1oRH4DmP+TNgq05Juc/dq/gRbqS7Q== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fwJTD2Q38zCTS; Tue, 14 Apr 2026 22:13:52 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 14 Apr 2026 15:13:49 -0700 From: Gleb Smirnoff To: John Baldwin , np@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="j5X9tIynpjCB0zDl" Content-Disposition: inline In-Reply-To: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> --j5X9tIynpjCB0zDl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote: J> The branch main has been updated by jhb: J> J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> Author: John Baldwin J> AuthorDate: 2026-04-14 18:07:51 +0000 J> Commit: John Baldwin J> CommitDate: 2026-04-14 18:07:51 +0000 J> J> tcp_close: Use in6_pcbdisconnect for INET6 sockets J> J> This also fixes the LINT-NOINET builds. J> J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") I think this change is also required. Almost sure it will fix panic observed by Navdeep. -- Gleb Smirnoff --j5X9tIynpjCB0zDl Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename=in6_pcbdisconnect.diff diff --git a/sys/netinet6/in6_pcb.c b/sys/netinet6/in6_pcb.c index ad596cf761d2..3750c7040fbc 100644 --- a/sys/netinet6/in6_pcb.c +++ b/sys/netinet6/in6_pcb.c @@ -531,6 +531,9 @@ in6_pcbdisconnect(struct inpcb *inp) KASSERT(inp->inp_smr == SMR_SEQ_INVALID, ("%s: inp %p was already disconnected", __func__, inp)); + if (inp->inp_flags & INP_UNCONNECTED) + return; + INP_HASH_WLOCK(inp->inp_pcbinfo); in_pcbremhash(inp); inp->inp_flags |= INP_UNCONNECTED; --j5X9tIynpjCB0zDl--